Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1434220 > unrolled thread

Re: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

Started byVinod Koul <vinod.koul@intel.com>
First post2016-06-30 06:30 +0200
Last post2016-06-30 07:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver  support Vinod Koul <vinod.koul@intel.com> - 2016-06-30 06:30 +0200
    RE: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver  support Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-06-30 07:50 +0200

#1434220 — Re: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

FromVinod Koul <vinod.koul@intel.com>
Date2016-06-30 06:30 +0200
SubjectRe: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support
Message-ID<rPBLY-4ZT-3@gated-at.bofh.it>
On Thu, Jun 09, 2016 at 09:07:47PM +0530, Kedareswara rao Appana wrote:

> +	dma_set_mask(&pdev->dev, DMA_BIT_MASK(44));
> +	dma_cap_set(DMA_SG, zdev->common.cap_mask);
> +	dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask);
 
>  /**
> + * struct zynqmp_dma_config - ZYNQMP DMA Configuration structure
> + * @ovrfetch: Overfetch status
> + * @has_sg: Support scatter gather transfers
> + * @ratectrl: Rate control value
> + * @src_issue: Out standing transactions on source
> + * @src_burst_len: Source burst length
> + * @dst_burst_len: Dest burst length
> + */

As discussed in other thread as well, this is no-go for memcpy. Please come
back after removing this

For slave usages use the dma_slave_config

-- 
~Vinod

[toc] | [next] | [standalone]


#1434234

FromAppana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
Date2016-06-30 07:50 +0200
Message-ID<rPD1n-5F9-3@gated-at.bofh.it>
In reply to#1434220
Hi Vinod,

> 
> On Thu, Jun 09, 2016 at 09:07:47PM +0530, Kedareswara rao Appana wrote:
> 
> > +	dma_set_mask(&pdev->dev, DMA_BIT_MASK(44));
> > +	dma_cap_set(DMA_SG, zdev->common.cap_mask);
> > +	dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask);
> 
> >  /**
> > + * struct zynqmp_dma_config - ZYNQMP DMA Configuration structure
> > + * @ovrfetch: Overfetch status
> > + * @has_sg: Support scatter gather transfers
> > + * @ratectrl: Rate control value
> > + * @src_issue: Out standing transactions on source
> > + * @src_burst_len: Source burst length
> > + * @dst_burst_len: Dest burst length
> > + */
> 
> As discussed in other thread as well, this is no-go for memcpy. Please come back
> after removing this
> 
> For slave usages use the dma_slave_config

Sure will fix in the next version...

Regards,
Kedar.

> 
> --
> ~Vinod

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web