RE: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

From	Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support
Date	2016-06-30 07:50 +0200
Message-ID	<rPD1n-5F9-3@gated-at.bofh.it> (permalink)
References	<rIadP-8fh-11@gated-at.bofh.it> <rIadP-8fh-9@gated-at.bofh.it> <rPBLY-4ZT-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Vinod,

> 
> On Thu, Jun 09, 2016 at 09:07:47PM +0530, Kedareswara rao Appana wrote:
> 
> > +	dma_set_mask(&pdev->dev, DMA_BIT_MASK(44));
> > +	dma_cap_set(DMA_SG, zdev->common.cap_mask);
> > +	dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask);
> 
> >  /**
> > + * struct zynqmp_dma_config - ZYNQMP DMA Configuration structure
> > + * @ovrfetch: Overfetch status
> > + * @has_sg: Support scatter gather transfers
> > + * @ratectrl: Rate control value
> > + * @src_issue: Out standing transactions on source
> > + * @src_burst_len: Source burst length
> > + * @dst_burst_len: Dest burst length
> > + */
> 
> As discussed in other thread as well, this is no-go for memcpy. Please come back
> after removing this
> 
> For slave usages use the dma_slave_config

Sure will fix in the next version...

Regards,
Kedar.

> 
> --
> ~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver  support Vinod Koul <vinod.koul@intel.com> - 2016-06-30 06:30 +0200
  RE: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver  support Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-06-30 07:50 +0200

csiph-web