Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1432919 > unrolled thread
| Started by | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| First post | 2016-06-28 14:00 +0200 |
| Last post | 2016-06-29 15:50 +0200 |
| Articles | 3 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-28 14:00 +0200
Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-29 14:20 +0200
Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-29 15:50 +0200
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-06-28 14:00 +0200 |
| Subject | Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33 |
| Message-ID | <rOZQm-6yo-29@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi, Thanks for working on this. On Tue, Jun 28, 2016 at 06:13:23PM +0800, Icenowy Zheng wrote: > This patch adds support for the sun8iw3 thermal sensor on > Allwinner A23/33 SoCs. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> The IP is awfully similar to the A31's, which already has a driver (drivers/input/touchscreen/sun4i-ts.c). There's no reason to add a new one here. Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-06-29 14:20 +0200 |
| Message-ID | <rPmDf-44F-17@gated-at.bofh.it> |
| In reply to | #1432919 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Tue, Jun 28, 2016 at 09:56:22PM +0800, Icenowy Zheng wrote: > The reason for a dedicate driver is: > 1. This IP have only thermal function, so it's not suitable to use a > driver at drivers/input/touchscreen/. That's not a problem, and it's being worked on [1]. > 2. Control Register are quite different. That's not a problem either, there's just a bit that you don't need to set in the control 1 register, and that's pretty much it. It doesn't justify a whole new driver. > 3. This IP uses AUDIO PLL (PLL2) as its clock! It's listed as the input, but all the rest of the documentation refers only to 24MHz, which seems to indicate that it's only running on the oscillator, which would make much more sense. Thanks, Maxime 1: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/439487.html -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-06-29 15:50 +0200 |
| Message-ID | <rPo2m-4Od-29@gated-at.bofh.it> |
| In reply to | #1433702 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Jun 29, 2016 at 09:31:39PM +0800, Icenowy Zheng wrote: > However, sun8iw3/5 ths is not even a GPADC... It's a specified IP, > only used as an ADC suitable for temperature sensor. It doesn't matter. It's the same IP, labelled differently. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web