Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33
Date	2016-06-29 14:20 +0200
Message-ID	<rPmDf-44F-17@gated-at.bofh.it> (permalink)
References	<rOZQm-6yo-31@gated-at.bofh.it> <rOZQm-6yo-33@gated-at.bofh.it> <rOZQm-6yo-29@gated-at.bofh.it> <rPmDf-44F-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Tue, Jun 28, 2016 at 09:56:22PM +0800, Icenowy Zheng wrote:
> The reason for a dedicate driver is:
> 1. This IP have only thermal function, so it's not suitable to use a
> driver at drivers/input/touchscreen/.

That's not a problem, and it's being worked on [1].

> 2. Control Register are quite different.

That's not a problem either, there's just a bit that you don't need to
set in the control 1 register, and that's pretty much it. It doesn't
justify a whole new driver.

> 3. This IP uses AUDIO PLL (PLL2) as its clock!

It's listed as the input, but all the rest of the documentation refers
only to 24MHz, which seems to indicate that it's only running on the
oscillator, which would make much more sense.

Thanks,
Maxime

1: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/439487.html

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thread

Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on  A23/33 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-28 14:00 +0200
  Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on  A23/33 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-29 14:20 +0200
    Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on  A23/33 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-29 15:50 +0200

csiph-web