Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1430592 > unrolled thread

[PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF Wang Nan <wangnan0@huawei.com> - 2016-06-24 13:30 +0200
    Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 14:30 +0200
      Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-27 21:10 +0200
    Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 14:30 +0200
      Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF pi3orama <pi3orama@163.com> - 2016-06-24 14:40 +0200
        Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 15:00 +0200
      Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-24 14:50 +0200
        Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF pi3orama <pi3orama@163.com> - 2016-06-24 14:50 +0200
          Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 15:10 +0200
        Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 14:50 +0200

#1430592 — [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
makes inconvience. For example, in perf script output we know which
process issue an event like this:

 compiz 19361 [001] 3275709.313929:  raw_syscalls:sys_exit: NR 7 = 0

After converting to CTF, we only get this:

  [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }

Currently, if we want to find the name and parent of a process, we
have to collect 'sched:sched_switch' event.

This patch set adds a '--all' option to 'perf convert', converts comm,
fork and exit events to CTF output. CTF user now can track the mapping
by their own.

v1 -> v2: Report number of sample and non-sample events when finish.
          rename opts.non_sample to opts.all.

Wang Nan (7):
  perf ctf: Add value_set_string() helper
  perf ctf: Pass convert options through opts structure
  perf ctf: Add 'all' option
  perf ctf: Prepare collect non-sample events
  perf ctf: Generate comm event to CTF output
  perf ctf: Add '--all' option for 'perf data convert'
  perf ctf: Generate fork and exit events to CTF output

 tools/perf/Documentation/perf-data.txt |   4 +
 tools/perf/builtin-data.c              |  11 +-
 tools/perf/util/data-convert-bt.c      | 195 ++++++++++++++++++++++++++++++++-
 tools/perf/util/data-convert-bt.h      |   4 +-
 tools/perf/util/data-convert.h         |   9 ++
 5 files changed, 216 insertions(+), 7 deletions(-)
 create mode 100644 tools/perf/util/data-convert.h

-- 
1.8.3.4

[toc] | [next] | [standalone]

#1430628 — Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote:
> After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
> makes inconvience. For example, in perf script output we know which
> process issue an event like this:
> 
>  compiz 19361 [001] 3275709.313929:  raw_syscalls:sys_exit: NR 7 = 0
> 
> After converting to CTF, we only get this:
> 
>   [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }
> 
> Currently, if we want to find the name and parent of a process, we
> have to collect 'sched:sched_switch' event.
> 
> This patch set adds a '--all' option to 'perf convert', converts comm,
> fork and exit events to CTF output. CTF user now can track the mapping
> by their own.
> 
> v1 -> v2: Report number of sample and non-sample events when finish.
>           rename opts.non_sample to opts.all.
> 
> Wang Nan (7):
>   perf ctf: Add value_set_string() helper
>   perf ctf: Pass convert options through opts structure
>   perf ctf: Add 'all' option
>   perf ctf: Prepare collect non-sample events
>   perf ctf: Generate comm event to CTF output
>   perf ctf: Add '--all' option for 'perf data convert'
>   perf ctf: Generate fork and exit events to CTF output

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

[toc] | [prev] | [next] | [standalone]

#1432226 — Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

Em Fri, Jun 24, 2016 at 02:28:51PM +0200, Jiri Olsa escreveu:
> On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote:
> > After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
> > makes inconvience. For example, in perf script output we know which
> > process issue an event like this:
> > 
> >  compiz 19361 [001] 3275709.313929:  raw_syscalls:sys_exit: NR 7 = 0
> > 
> > After converting to CTF, we only get this:
> > 
> >   [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }
> > 
> > Currently, if we want to find the name and parent of a process, we
> > have to collect 'sched:sched_switch' event.
> > 
> > This patch set adds a '--all' option to 'perf convert', converts comm,
> > fork and exit events to CTF output. CTF user now can track the mapping
> > by their own.
> > 
> > v1 -> v2: Report number of sample and non-sample events when finish.
> >           rename opts.non_sample to opts.all.
> > 
> > Wang Nan (7):
> >   perf ctf: Add value_set_string() helper
> >   perf ctf: Pass convert options through opts structure
> >   perf ctf: Add 'all' option
> >   perf ctf: Prepare collect non-sample events
> >   perf ctf: Generate comm event to CTF output
> >   perf ctf: Add '--all' option for 'perf data convert'
> >   perf ctf: Generate fork and exit events to CTF output
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.

- Arnaldo
- Arnaldo

[toc] | [prev] | [next] | [standalone]

#1430630 — Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote:
> After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
> makes inconvience. For example, in perf script output we know which
> process issue an event like this:
> 
>  compiz 19361 [001] 3275709.313929:  raw_syscalls:sys_exit: NR 7 = 0
> 
> After converting to CTF, we only get this:
> 
>   [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }
> 
> Currently, if we want to find the name and parent of a process, we
> have to collect 'sched:sched_switch' event.
> 
> This patch set adds a '--all' option to 'perf convert', converts comm,
> fork and exit events to CTF output. CTF user now can track the mapping
> by their own.
> 
> v1 -> v2: Report number of sample and non-sample events when finish.
>           rename opts.non_sample to opts.all.
> 
> Wang Nan (7):
>   perf ctf: Add value_set_string() helper
>   perf ctf: Pass convert options through opts structure
>   perf ctf: Add 'all' option
>   perf ctf: Prepare collect non-sample events
>   perf ctf: Generate comm event to CTF output
>   perf ctf: Add '--all' option for 'perf data convert'
>   perf ctf: Generate fork and exit events to CTF output

I can't compile unless I can include config.h

[jolsa@krava perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
  BUILD:   Doing 'make -j4' parallel build
  CC       util/data-convert-bt.o
util/data-convert-bt.c: In function ‘convert__config’:
util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
   c->queue_size = perf_config_u64(var, value);
                   ^
util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
   c->queue_size = perf_config_u64(var, value);
   ^
util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
  perf_config(convert__config, &c);
  ^
util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs]
cc1: all warnings being treated as errors


your compiler's not that strict I guess ;-)
I'll post it shortly

jirka

---
diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index 79082782e7d2..4b68e7b9ee0c 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -26,6 +26,7 @@
 #include "evlist.h"
 #include "evsel.h"
 #include "machine.h"
+#include "config.h"
 
 #define pr_N(n, fmt, ...) \
 	eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__)

[toc] | [prev] | [next] | [standalone]

#1430634

发自我的 iPhone

> 在 2016年6月24日，下午8:29，Jiri Olsa <jolsa@redhat.com> 写道：
> 
>> On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote:
>> After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
>> makes inconvience. For example, in perf script output we know which
>> process issue an event like this:
>> 
>> compiz 19361 [001] 3275709.313929:  raw_syscalls:sys_exit: NR 7 = 0
>> 
>> After converting to CTF, we only get this:
>> 
>>  [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }
>> 
>> Currently, if we want to find the name and parent of a process, we
>> have to collect 'sched:sched_switch' event.
>> 
>> This patch set adds a '--all' option to 'perf convert', converts comm,
>> fork and exit events to CTF output. CTF user now can track the mapping
>> by their own.
>> 
>> v1 -> v2: Report number of sample and non-sample events when finish.
>>          rename opts.non_sample to opts.all.
>> 
>> Wang Nan (7):
>>  perf ctf: Add value_set_string() helper
>>  perf ctf: Pass convert options through opts structure
>>  perf ctf: Add 'all' option
>>  perf ctf: Prepare collect non-sample events
>>  perf ctf: Generate comm event to CTF output
>>  perf ctf: Add '--all' option for 'perf data convert'
>>  perf ctf: Generate fork and exit events to CTF output
> 
> I can't compile unless I can include config.h
> 
> [jolsa@krava perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
>  BUILD:   Doing 'make -j4' parallel build
>  CC       util/data-convert-bt.o
> util/data-convert-bt.c: In function ‘convert__config’:
> util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
>   c->queue_size = perf_config_u64(var, value);
>                   ^
> util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
>   c->queue_size = perf_config_u64(var, value);
>   ^
> util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
> util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
>  perf_config(convert__config, &c);
>  ^
> util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors
> 

Strange.

The error message seems unrelated to my
patch, right?

Thank you.

> 
> your compiler's not that strict I guess ;-)
> I'll post it shortly
> 
> jirka
> 
> ---
> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> index 79082782e7d2..4b68e7b9ee0c 100644
> --- a/tools/perf/util/data-convert-bt.c
> +++ b/tools/perf/util/data-convert-bt.c
> @@ -26,6 +26,7 @@
> #include "evlist.h"
> #include "evsel.h"
> #include "machine.h"
> +#include "config.h"
> 
> #define pr_N(n, fmt, ...) \
>    eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__)

[toc] | [prev] | [next] | [standalone]

#1430644 — Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

On Fri, Jun 24, 2016 at 08:33:27PM +0800, pi3orama wrote:

SNIP

> > I can't compile unless I can include config.h
> > 
> > [jolsa@krava perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
> >  BUILD:   Doing 'make -j4' parallel build
> >  CC       util/data-convert-bt.o
> > util/data-convert-bt.c: In function ‘convert__config’:
> > util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
> >   c->queue_size = perf_config_u64(var, value);
> >                   ^
> > util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
> >   c->queue_size = perf_config_u64(var, value);
> >   ^
> > util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
> > util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
> >  perf_config(convert__config, &c);
> >  ^
> > util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs]
> > cc1: all warnings being treated as errors
> > 
> 
> Strange.
> 
> The error message seems unrelated to my
> patch, right?

yep, it's unrelated and I just posted the fix

I haven't enabled/compiled this code for a while and that's
what I've got.. I assume we're using different compilers

jirka

[toc] | [prev] | [next] | [standalone]

#1430635 — Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

Em Fri, Jun 24, 2016 at 02:29:07PM +0200, Jiri Olsa escreveu:
> On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote:
> > After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
> > makes inconvience. For example, in perf script output we know which
> > process issue an event like this:
> > 
> >  compiz 19361 [001] 3275709.313929:  raw_syscalls:sys_exit: NR 7 = 0
> > 
> > After converting to CTF, we only get this:
> > 
> >   [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }
> > 
> > Currently, if we want to find the name and parent of a process, we
> > have to collect 'sched:sched_switch' event.
> > 
> > This patch set adds a '--all' option to 'perf convert', converts comm,
> > fork and exit events to CTF output. CTF user now can track the mapping
> > by their own.
> > 
> > v1 -> v2: Report number of sample and non-sample events when finish.
> >           rename opts.non_sample to opts.all.
> > 
> > Wang Nan (7):
> >   perf ctf: Add value_set_string() helper
> >   perf ctf: Pass convert options through opts structure
> >   perf ctf: Add 'all' option
> >   perf ctf: Prepare collect non-sample events
> >   perf ctf: Generate comm event to CTF output
> >   perf ctf: Add '--all' option for 'perf data convert'
> >   perf ctf: Generate fork and exit events to CTF output
> 
> I can't compile unless I can include config.h

Waiting for this fix to proceed, but it seems we don't have this covered
in 'build-test', right? ;-)

- Arnaldo
 
> [jolsa@krava perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
>   BUILD:   Doing 'make -j4' parallel build
>   CC       util/data-convert-bt.o
> util/data-convert-bt.c: In function ‘convert__config’:
> util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
>    c->queue_size = perf_config_u64(var, value);
>                    ^
> util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
>    c->queue_size = perf_config_u64(var, value);
>    ^
> util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
> util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
>   perf_config(convert__config, &c);
>   ^
> util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors
> 
> 
> your compiler's not that strict I guess ;-)
> I'll post it shortly
> 
> jirka
> 
> ---
> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> index 79082782e7d2..4b68e7b9ee0c 100644
> --- a/tools/perf/util/data-convert-bt.c
> +++ b/tools/perf/util/data-convert-bt.c
> @@ -26,6 +26,7 @@
>  #include "evlist.h"
>  #include "evsel.h"
>  #include "machine.h"
> +#include "config.h"
>  
>  #define pr_N(n, fmt, ...) \
>  	eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__)

[toc] | [prev] | [next] | [standalone]

#1430639

发自我的 iPhone

> 在 2016年6月24日，下午8:41，Arnaldo Carvalho de Melo <acme@kernel.org> 写道：
> 
> Em Fri, Jun 24, 2016 at 02:29:07PM +0200, Jiri Olsa escreveu:
>> On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote:
>>> After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
>>> makes inconvience. For example, in perf script output we know which
>>> process issue an event like this:
>>> 
>>> compiz 19361 [001] 3275709.313929:  raw_syscalls:sys_exit: NR 7 = 0
>>> 
>>> After converting to CTF, we only get this:
>>> 
>>>  [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }
>>> 
>>> Currently, if we want to find the name and parent of a process, we
>>> have to collect 'sched:sched_switch' event.
>>> 
>>> This patch set adds a '--all' option to 'perf convert', converts comm,
>>> fork and exit events to CTF output. CTF user now can track the mapping
>>> by their own.
>>> 
>>> v1 -> v2: Report number of sample and non-sample events when finish.
>>>          rename opts.non_sample to opts.all.
>>> 
>>> Wang Nan (7):
>>>  perf ctf: Add value_set_string() helper
>>>  perf ctf: Pass convert options through opts structure
>>>  perf ctf: Add 'all' option
>>>  perf ctf: Prepare collect non-sample events
>>>  perf ctf: Generate comm event to CTF output
>>>  perf ctf: Add '--all' option for 'perf data convert'
>>>  perf ctf: Generate fork and exit events to CTF output
>> 
>> I can't compile unless I can include config.h
> 
> Waiting for this fix to proceed, but it seems we don't have this covered
> in 'build-test', right? ;-)
> 

CTF support is off by default. When can we
turn it on like other options?

Thank you.

> - Arnaldo
> 
>> [jolsa@krava perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
>>  BUILD:   Doing 'make -j4' parallel build
>>  CC       util/data-convert-bt.o
>> util/data-convert-bt.c: In function ‘convert__config’:
>> util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
>>   c->queue_size = perf_config_u64(var, value);
>>                   ^
>> util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
>>   c->queue_size = perf_config_u64(var, value);
>>   ^
>> util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
>> util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
>>  perf_config(convert__config, &c);
>>  ^
>> util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs]
>> cc1: all warnings being treated as errors
>> 
>> 
>> your compiler's not that strict I guess ;-)
>> I'll post it shortly
>> 
>> jirka
>> 
>> ---
>> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
>> index 79082782e7d2..4b68e7b9ee0c 100644
>> --- a/tools/perf/util/data-convert-bt.c
>> +++ b/tools/perf/util/data-convert-bt.c
>> @@ -26,6 +26,7 @@
>> #include "evlist.h"
>> #include "evsel.h"
>> #include "machine.h"
>> +#include "config.h"
>> 
>> #define pr_N(n, fmt, ...) \
>>    eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__)

[toc] | [prev] | [next] | [standalone]

#1430646 — Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

On Fri, Jun 24, 2016 at 08:43:56PM +0800, pi3orama wrote:
> 
> 
> 发自我的 iPhone
> 
> > 在 2016年6月24日，下午8:41，Arnaldo Carvalho de Melo <acme@kernel.org> 写道：
> > 
> > Em Fri, Jun 24, 2016 at 02:29:07PM +0200, Jiri Olsa escreveu:
> >> On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote:
> >>> After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
> >>> makes inconvience. For example, in perf script output we know which
> >>> process issue an event like this:
> >>> 
> >>> compiz 19361 [001] 3275709.313929:  raw_syscalls:sys_exit: NR 7 = 0
> >>> 
> >>> After converting to CTF, we only get this:
> >>> 
> >>>  [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }
> >>> 
> >>> Currently, if we want to find the name and parent of a process, we
> >>> have to collect 'sched:sched_switch' event.
> >>> 
> >>> This patch set adds a '--all' option to 'perf convert', converts comm,
> >>> fork and exit events to CTF output. CTF user now can track the mapping
> >>> by their own.
> >>> 
> >>> v1 -> v2: Report number of sample and non-sample events when finish.
> >>>          rename opts.non_sample to opts.all.
> >>> 
> >>> Wang Nan (7):
> >>>  perf ctf: Add value_set_string() helper
> >>>  perf ctf: Pass convert options through opts structure
> >>>  perf ctf: Add 'all' option
> >>>  perf ctf: Prepare collect non-sample events
> >>>  perf ctf: Generate comm event to CTF output
> >>>  perf ctf: Add '--all' option for 'perf data convert'
> >>>  perf ctf: Generate fork and exit events to CTF output
> >> 
> >> I can't compile unless I can include config.h
> > 
> > Waiting for this fix to proceed, but it seems we don't have this covered
> > in 'build-test', right? ;-)
> > 
> 
> CTF support is off by default. When can we
> turn it on like other options?

we switched it off because the latest version we needed
wasn't part of main distros.. it might have changed now

jirka

[toc] | [prev] | [next] | [standalone]

#1430643 — Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

On Fri, Jun 24, 2016 at 09:41:13AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 24, 2016 at 02:29:07PM +0200, Jiri Olsa escreveu:
> > On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote:
> > > After converting perf.data to CTF, we lost pid-tid-comm mapping. Which
> > > makes inconvience. For example, in perf script output we know which
> > > process issue an event like this:
> > > 
> > >  compiz 19361 [001] 3275709.313929:  raw_syscalls:sys_exit: NR 7 = 0
> > > 
> > > After converting to CTF, we only get this:
> > > 
> > >   [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 }
> > > 
> > > Currently, if we want to find the name and parent of a process, we
> > > have to collect 'sched:sched_switch' event.
> > > 
> > > This patch set adds a '--all' option to 'perf convert', converts comm,
> > > fork and exit events to CTF output. CTF user now can track the mapping
> > > by their own.
> > > 
> > > v1 -> v2: Report number of sample and non-sample events when finish.
> > >           rename opts.non_sample to opts.all.
> > > 
> > > Wang Nan (7):
> > >   perf ctf: Add value_set_string() helper
> > >   perf ctf: Pass convert options through opts structure
> > >   perf ctf: Add 'all' option
> > >   perf ctf: Prepare collect non-sample events
> > >   perf ctf: Generate comm event to CTF output
> > >   perf ctf: Add '--all' option for 'perf data convert'
> > >   perf ctf: Generate fork and exit events to CTF output
> > 
> > I can't compile unless I can include config.h
> 
> Waiting for this fix to proceed, but it seems we don't have this covered

just posted it ;-)

> in 'build-test', right? ;-)

right, but we dont cover babletrace stuff in tests/make

jirka

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web