Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF
Date	2016-06-24 15:00 +0200
Message-ID	<rNySd-8bp-1@gated-at.bofh.it> (permalink)
References	<rNxt7-7os-3@gated-at.bofh.it> <rNypb-7Zv-17@gated-at.bofh.it> <rNyyR-82N-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 24, 2016 at 08:33:27PM +0800, pi3orama wrote:

SNIP

> > I can't compile unless I can include config.h
> > 
> > [jolsa@krava perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
> >  BUILD:   Doing 'make -j4' parallel build
> >  CC       util/data-convert-bt.o
> > util/data-convert-bt.c: In function ‘convert__config’:
> > util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
> >   c->queue_size = perf_config_u64(var, value);
> >                   ^
> > util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
> >   c->queue_size = perf_config_u64(var, value);
> >   ^
> > util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
> > util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
> >  perf_config(convert__config, &c);
> >  ^
> > util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs]
> > cc1: all warnings being treated as errors
> > 
> 
> Strange.
> 
> The error message seems unrelated to my
> patch, right?

yep, it's unrelated and I just posted the fix

I haven't enabled/compiled this code for a while and that's
what I've got.. I assume we're using different compilers

jirka

Thread

[PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF Wang Nan <wangnan0@huawei.com> - 2016-06-24 13:30 +0200
  Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 14:30 +0200
    Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-27 21:10 +0200
  Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 14:30 +0200
    Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF pi3orama <pi3orama@163.com> - 2016-06-24 14:40 +0200
      Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 15:00 +0200
    Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-24 14:50 +0200
      Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF pi3orama <pi3orama@163.com> - 2016-06-24 14:50 +0200
        Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 15:10 +0200
      Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to  CTF Jiri Olsa <jolsa@redhat.com> - 2016-06-24 14:50 +0200

csiph-web