Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1429585 > unrolled thread

[PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

Started byAllen Hung <allen_hung@dell.com>
First post2016-06-23 10:40 +0200
Last post2016-06-30 16:50 +0200
Articles 9 — 6 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" Allen Hung <allen_hung@dell.com> - 2016-06-23 10:40 +0200
    Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Andy Lutomirski <luto@kernel.org> - 2016-06-27 20:00 +0200
      Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Andy Lutomirski <luto@amacapital.net> - 2016-06-28 00:30 +0200
        Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Andy Lutomirski <luto@amacapital.net> - 2016-06-28 19:50 +0200
      Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Jiri Kosina <jikos@kernel.org> - 2016-06-28 13:30 +0200
    Re: [1/2] Revert "HID: multitouch: enable palm rejection if device  implements confidence usage" Mario Limonciello <mario_limonciello@dell.com> - 2016-06-28 00:20 +0200
    Re: [1/2] Revert "HID: multitouch: enable palm rejection if device  implements confidence usage" Mario Limonciello <mario_limonciello@dell.com> - 2016-06-29 20:40 +0200
      Re: [1/2] Revert "HID: multitouch: enable palm rejection if device  implements confidence usage" Jiri Kosina <jikos@kernel.org> - 2016-06-30 09:40 +0200
        RE: [1/2] Revert "HID: multitouch: enable palm rejection if device  implements confidence usage" <Mario_Limonciello@Dell.com> - 2016-06-30 16:50 +0200

#1429585 — [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

FromAllen Hung <allen_hung@dell.com>
Date2016-06-23 10:40 +0200
Subject[PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Message-ID<rN8l4-7kx-19@gated-at.bofh.it>
This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection
if device implements confidence usage")

The commit enables palm rejection for Win8 Precision Touchpad devices but
the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very
properly. This quirk is originally designed for some WIn7 touchscreens. Use
of this for a Win8 Precision Touchpad will cause unexpected pointer jumping
problem.

Signed-off-by: Allen Hung <allen_hung@dell.com>
---
 drivers/hid/hid-multitouch.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 95b7d61..4ef7006 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
 			mt_store_field(usage, td, hi);
 			return 1;
 		case HID_DG_CONFIDENCE:
-			if (cls->name == MT_CLS_WIN_8 &&
-				field->application == HID_DG_TOUCHPAD) {
-				cls->quirks &= ~MT_QUIRK_ALWAYS_VALID;
-				cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE;
-			}
 			mt_store_field(usage, td, hi);
 			return 1;
 		case HID_DG_TIPSWITCH:
-- 
2.7.4

[toc] | [next] | [standalone]

#1432201 — Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

FromAndy Lutomirski <luto@kernel.org>
Date2016-06-27 20:00 +0200
SubjectRe: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Message-ID<rOIZb-3tG-5@gated-at.bofh.it>
In reply to#1429585
On 06/23/2016 01:31 AM, Allen Hung wrote:
> This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection
> if device implements confidence usage")
>
> The commit enables palm rejection for Win8 Precision Touchpad devices but
> the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very
> properly. This quirk is originally designed for some WIn7 touchscreens. Use
> of this for a Win8 Precision Touchpad will cause unexpected pointer jumping
> problem.
>
> Signed-off-by: Allen Hung <allen_hung@dell.com>
> ---
>  drivers/hid/hid-multitouch.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 95b7d61..4ef7006 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>  			mt_store_field(usage, td, hi);
>  			return 1;
>  		case HID_DG_CONFIDENCE:
> -			if (cls->name == MT_CLS_WIN_8 &&
> -				field->application == HID_DG_TOUCHPAD) {
> -				cls->quirks &= ~MT_QUIRK_ALWAYS_VALID;
> -				cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE;
> -			}
>  			mt_store_field(usage, td, hi);
>  			return 1;
>  		case HID_DG_TIPSWITCH:
>

This and patch 2 are:

Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3

(And I'm curious why 1.4.3 seems to have been pulled.  Might it have 
been this issue?  For better or for worse, I upgraded in the narrow 
window in which it was available on Dell's website.)

--Andy

[toc] | [prev] | [next] | [standalone]

#1432346 — Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

FromAndy Lutomirski <luto@amacapital.net>
Date2016-06-28 00:30 +0200
SubjectRe: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Message-ID<rONct-6pd-3@gated-at.bofh.it>
In reply to#1432201
On Mon, Jun 27, 2016 at 10:55 AM, Andy Lutomirski <luto@kernel.org> wrote:
> On 06/23/2016 01:31 AM, Allen Hung wrote:
>>
>> This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection
>> if device implements confidence usage")
>>
>> The commit enables palm rejection for Win8 Precision Touchpad devices but
>> the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very
>> properly. This quirk is originally designed for some WIn7 touchscreens.
>> Use
>> of this for a Win8 Precision Touchpad will cause unexpected pointer
>> jumping
>> problem.
>>
>> Signed-off-by: Allen Hung <allen_hung@dell.com>
>> ---
>>  drivers/hid/hid-multitouch.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 95b7d61..4ef7006 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device
>> *hdev, struct hid_input *hi,
>>                         mt_store_field(usage, td, hi);
>>                         return 1;
>>                 case HID_DG_CONFIDENCE:
>> -                       if (cls->name == MT_CLS_WIN_8 &&
>> -                               field->application == HID_DG_TOUCHPAD) {
>> -                               cls->quirks &= ~MT_QUIRK_ALWAYS_VALID;
>> -                               cls->quirks |=
>> MT_QUIRK_VALID_IS_CONFIDENCE;
>> -                       }
>>                         mt_store_field(usage, td, hi);
>>                         return 1;
>>                 case HID_DG_TIPSWITCH:
>>
>
> This and patch 2 are:
>
> Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3
>
> (And I'm curious why 1.4.3 seems to have been pulled.  Might it have been
> this issue?  For better or for worse, I upgraded in the narrow window in
> which it was available on Dell's website.)
>

I should amend that Tested-by slightly: these patches seem to make the
problem merely about as bad as it was before.  It's still not perfect
-- I still occasionally get stuck touches.

--Andy

[toc] | [prev] | [next] | [standalone]

#1433184 — Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

FromAndy Lutomirski <luto@amacapital.net>
Date2016-06-28 19:50 +0200
SubjectRe: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Message-ID<rP5j3-1EC-13@gated-at.bofh.it>
In reply to#1432346
On Mon, Jun 27, 2016 at 3:25 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Jun 27, 2016 at 10:55 AM, Andy Lutomirski <luto@kernel.org> wrote:
>>
>> This and patch 2 are:
>>
>> Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3
>>
>> (And I'm curious why 1.4.3 seems to have been pulled.  Might it have been
>> this issue?  For better or for worse, I upgraded in the narrow window in
>> which it was available on Dell's website.)
>>
>
> I should amend that Tested-by slightly: these patches seem to make the
> problem merely about as bad as it was before.  It's still not perfect
> -- I still occasionally get stuck touches.

On further investigation, I'm not getting stuck touches AFAICT.  I'm
experiencing an upgraded version of libinput being clever and
incorrectly deciding that I middle-clicked.  Sorry for the noise.

https://bugs.freedesktop.org/show_bug.cgi?id=96710

--Andy

[toc] | [prev] | [next] | [standalone]

#1432878 — Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

FromJiri Kosina <jikos@kernel.org>
Date2016-06-28 13:30 +0200
SubjectRe: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Message-ID<rOZnk-6lK-15@gated-at.bofh.it>
In reply to#1432201
Hi,

I've applied the series to hid.git#for-4.7/upstream-fixes

Thanks everybody,

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1432345 — Re: [1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

FromMario Limonciello <mario_limonciello@dell.com>
Date2016-06-28 00:20 +0200
SubjectRe: [1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Message-ID<rON2N-6lM-7@gated-at.bofh.it>
In reply to#1429585
Andy,

> (And I'm curious why 1.4.3 seems to have been pulled.  Might it have
> been this issue?  For better or for worse, I upgraded in the narrow
> window in which it was available on Dell's website.)

It wasn't pulled in relation to this issue.  It was something else. 
Nothing I'm aware of in the 1.4.3 BIOS changes should have made this any
worse than previously.  Maybe something else in the stack moved that
exaggerated the problem or you started palming the touchpad more?

Your Tested-by: is that meaning that it's fixed entirely for you?  Not
getting stuck at all now?

Thanks,

[toc] | [prev] | [next] | [standalone]

#1433964 — Re: [1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

FromMario Limonciello <mario_limonciello@dell.com>
Date2016-06-29 20:40 +0200
SubjectRe: [1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Message-ID<rPsyZ-7FB-21@gated-at.bofh.it>
In reply to#1429585
> I've applied the series to hid.git#for-4.7/upstream-fixes

Hi Jiri,

Would you also submit this to -stable? 
I think it should be generally applicable at least a few releases back
since Allen's original submit.

Thanks,

[toc] | [prev] | [next] | [standalone]

#1434306 — Re: [1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

FromJiri Kosina <jikos@kernel.org>
Date2016-06-30 09:40 +0200
SubjectRe: [1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Message-ID<rPEJQ-6JB-25@gated-at.bofh.it>
In reply to#1433964
On Wed, 29 Jun 2016, Mario Limonciello wrote:

> Would you also submit this to -stable? 
> I think it should be generally applicable at least a few releases back
> since Allen's original submit.

Both commits (already in Linus' tree as of today) contain the -stable 
kernel annotation.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1434633 — RE: [1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

From<Mario_Limonciello@Dell.com>
Date2016-06-30 16:50 +0200
SubjectRE: [1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Message-ID<rPLrX-2lA-5@gated-at.bofh.it>
In reply to#1434306
> -----Original Message-----
> From: Jiri Kosina [mailto:jikos@kernel.org]
> Sent: Thursday, June 30, 2016 2:40 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: Hung, Allen <Allen_Hung@Dell.com>; Benjamin Tissoires
> <benjamin.tissoires@redhat.com>; linux-input@vger.kernel.org; LKML
> <linux-kernel@vger.kernel.org>
> Subject: Re: [1/2] Revert "HID: multitouch: enable palm rejection if device
> implements confidence usage"
> 
> On Wed, 29 Jun 2016, Mario Limonciello wrote:
> 
> > Would you also submit this to -stable?
> > I think it should be generally applicable at least a few releases back
> > since Allen's original submit.
> 
> Both commits (already in Linus' tree as of today) contain the -stable
> kernel annotation.
> 
> --
> Jiri Kosina
> SUSE Labs

Sorry I missed that, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web