Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1429585

[PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"

From Allen Hung <allen_hung@dell.com>
Newsgroups linux.kernel
Subject [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Date 2016-06-23 10:40 +0200
Message-ID <rN8l4-7kx-19@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw

This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection
if device implements confidence usage")

The commit enables palm rejection for Win8 Precision Touchpad devices but
the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very
properly. This quirk is originally designed for some WIn7 touchscreens. Use
of this for a Win8 Precision Touchpad will cause unexpected pointer jumping
problem.

Signed-off-by: Allen Hung <allen_hung@dell.com>
---
 drivers/hid/hid-multitouch.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 95b7d61..4ef7006 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
 			mt_store_field(usage, td, hi);
 			return 1;
 		case HID_DG_CONFIDENCE:
-			if (cls->name == MT_CLS_WIN_8 &&
-				field->application == HID_DG_TOUCHPAD) {
-				cls->quirks &= ~MT_QUIRK_ALWAYS_VALID;
-				cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE;
-			}
 			mt_store_field(usage, td, hi);
 			return 1;
 		case HID_DG_TIPSWITCH:
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" Allen Hung <allen_hung@dell.com> - 2016-06-23 10:40 +0200
  Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Andy Lutomirski <luto@kernel.org> - 2016-06-27 20:00 +0200
    Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Andy Lutomirski <luto@amacapital.net> - 2016-06-28 00:30 +0200
      Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Andy Lutomirski <luto@amacapital.net> - 2016-06-28 19:50 +0200
    Re: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if  device implements confidence usage" Jiri Kosina <jikos@kernel.org> - 2016-06-28 13:30 +0200
  Re: [1/2] Revert "HID: multitouch: enable palm rejection if device  implements confidence usage" Mario Limonciello <mario_limonciello@dell.com> - 2016-06-28 00:20 +0200
  Re: [1/2] Revert "HID: multitouch: enable palm rejection if device  implements confidence usage" Mario Limonciello <mario_limonciello@dell.com> - 2016-06-29 20:40 +0200
    Re: [1/2] Revert "HID: multitouch: enable palm rejection if device  implements confidence usage" Jiri Kosina <jikos@kernel.org> - 2016-06-30 09:40 +0200
      RE: [1/2] Revert "HID: multitouch: enable palm rejection if device  implements confidence usage" <Mario_Limonciello@Dell.com> - 2016-06-30 16:50 +0200

csiph-web