Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425737 > unrolled thread
| Started by | Tomasz Figa <tomasz.figa@gmail.com> |
|---|---|
| First post | 2016-06-18 16:50 +0200 |
| Last post | 2016-06-20 15:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks Tomasz Figa <tomasz.figa@gmail.com> - 2016-06-18 16:50 +0200
Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-06-20 15:40 +0200
| From | Tomasz Figa <tomasz.figa@gmail.com> |
|---|---|
| Date | 2016-06-18 16:50 +0200 |
| Subject | Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks |
| Message-ID | <rLpJo-5ix-11@gated-at.bofh.it> |
Hi Bartlomiej, 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>: > Open-code samsung_cmu_register_one() calls for CMU_APOLLO and > CMU_ATLAS setup code as a preparation for adding CPU clocks > support for Exynos5433. Why do we need to open code it? Even if it's really necessary, it would make sense to state it in the commit description for lazy readers reviewing the patches in order. :) Best regards, Tomasz
[toc] | [next] | [standalone]
| From | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
|---|---|
| Date | 2016-06-20 15:40 +0200 |
| Message-ID | <rM7AK-nl-29@gated-at.bofh.it> |
| In reply to | #1425737 |
Hi Tomasz, On Saturday, June 18, 2016 11:40:05 PM Tomasz Figa wrote: > Hi Bartlomiej, > > 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>: > > Open-code samsung_cmu_register_one() calls for CMU_APOLLO and > > CMU_ATLAS setup code as a preparation for adding CPU clocks > > support for Exynos5433. > > Why do we need to open code it? Even if it's really necessary, it We want to register CPU clock before calling samsung_clk_sleep_init() and samsung_clk_of_add_provider() (just as we do it on other Exynos SoCs) so we cannot use samsung_cmu_register_one() helper. > would make sense to state it in the commit description for lazy > readers reviewing the patches in order. :) Right, sorry about that. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web