Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks

From	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks
Date	2016-06-20 15:40 +0200
Message-ID	<rM7AK-nl-29@gated-at.bofh.it> (permalink)
References	<rCkzf-3M3-3@gated-at.bofh.it> <rCkzg-3M3-5@gated-at.bofh.it> <rLpJo-5ix-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Tomasz,

On Saturday, June 18, 2016 11:40:05 PM Tomasz Figa wrote:
> Hi Bartlomiej,
> 
> 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > Open-code samsung_cmu_register_one() calls for CMU_APOLLO and
> > CMU_ATLAS setup code as a preparation for adding CPU clocks
> > support for Exynos5433.
> 
> Why do we need to open code it? Even if it's really necessary, it

We want to register CPU clock before calling samsung_clk_sleep_init()
and samsung_clk_of_add_provider() (just as we do it on other Exynos
SoCs) so we cannot use samsung_cmu_register_one() helper.

> would make sense to state it in the commit description for lazy
> readers reviewing the patches in order. :)

Right, sorry about that.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks Tomasz Figa <tomasz.figa@gmail.com> - 2016-06-18 16:50 +0200
  Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-06-20 15:40 +0200

csiph-web