Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425631 > unrolled thread

Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters  issue in s626.c Greg KH <gregkh@linuxfoundation.org> - 2016-06-18 06:00 +0200
    Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue  in s626.c Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-18 16:30 +0200

#1425631 — Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

On Mon, May 30, 2016 at 03:21:27PM +0100, Luis de Bethencourt wrote:
> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> > This is a patch to the s626.c file that fixes up a  line over 80
> > characters issues found by the checkpatch.pl tool.
> > 
> > Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> 
> Looks good :)
> 
> This is the only instance of the line over 80 characters Warning in that file.
> 
> Like previous patches, no need to mention the file being fixed in the commit
> message. It isn't a big deal though.
> 
> +1

Not much I can do with at "+1", please respond with a:
	Acked-by:
or even better:
	Reviewed-by:

with the proper info, so I can add it to the patch and give you credit
for reviewing it.

thanks,

greg k-h

[toc] | [next] | [standalone]

#1425725 — Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

On 18/06/16 04:51, Greg KH wrote:
> On Mon, May 30, 2016 at 03:21:27PM +0100, Luis de Bethencourt wrote:
>> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
>>> This is a patch to the s626.c file that fixes up a  line over 80
>>> characters issues found by the checkpatch.pl tool.
>>>
>>> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
>>
>> Looks good :)
>>
>> This is the only instance of the line over 80 characters Warning in that file.
>>
>> Like previous patches, no need to mention the file being fixed in the commit
>> message. It isn't a big deal though.
>>
>> +1
> 
> Not much I can do with at "+1", please respond with a:
> 	Acked-by:
> or even better:
> 	Reviewed-by:
> 
> with the proper info, so I can add it to the patch and give you credit
> for reviewing it.
> 
> thanks,
> 
> greg k-h
> 

Reviewed-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Sorry, sometimes I am not sure if my comments warrant an Acked-by/Reviewed-by.

Will always add one from now on.

Thanks :)
Luis

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web