Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c
Date	2016-06-18 16:30 +0200
Message-ID	<rLpq2-5bE-1@gated-at.bofh.it> (permalink)
References	<rDEYV-4Tt-3@gated-at.bofh.it> <rDEYV-4Tt-1@gated-at.bofh.it> <rEwmB-5kR-11@gated-at.bofh.it> <rLfAl-7bC-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 18/06/16 04:51, Greg KH wrote:
> On Mon, May 30, 2016 at 03:21:27PM +0100, Luis de Bethencourt wrote:
>> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
>>> This is a patch to the s626.c file that fixes up a  line over 80
>>> characters issues found by the checkpatch.pl tool.
>>>
>>> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
>>
>> Looks good :)
>>
>> This is the only instance of the line over 80 characters Warning in that file.
>>
>> Like previous patches, no need to mention the file being fixed in the commit
>> message. It isn't a big deal though.
>>
>> +1
> 
> Not much I can do with at "+1", please respond with a:
> 	Acked-by:
> or even better:
> 	Reviewed-by:
> 
> with the proper info, so I can add it to the patch and give you credit
> for reviewing it.
> 
> thanks,
> 
> greg k-h
> 

Reviewed-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Sorry, sometimes I am not sure if my comments warrant an Acked-by/Reviewed-by.

Will always add one from now on.

Thanks :)
Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters  issue in s626.c Greg KH <gregkh@linuxfoundation.org> - 2016-06-18 06:00 +0200
  Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue  in s626.c Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-18 16:30 +0200

csiph-web