Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425523 > unrolled thread

Re: [drm] e28cd4d0a2: INFO: trying to register non-static key.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [drm]  e28cd4d0a2: INFO: trying to register non-static key. Chris Wilson <chris@chris-wilson.co.uk> - 2016-06-18 00:20 +0200
    Re: [drm] e28cd4d0a2: INFO: trying to register non-static key. Daniel Vetter <daniel.vetter@ffwll.ch> - 2016-06-18 00:50 +0200

#1425523 — Re: [drm] e28cd4d0a2: INFO: trying to register non-static key.

On Sat, Jun 18, 2016 at 05:24:30AM +0800, kernel test robot wrote:
> 
> 
> FYI, we noticed the following commit:
> 
> git://anongit.freedesktop.org/drm-intel topic/drm-misc
> commit e28cd4d0a223e1bcea616326e2281900e7e7e9a2 ("drm: Automatically register/unregister all connectors")
> 
> 
> on test machine: vm-lkp-wsx03-yocto-i386: 1 threads qemu-system-i386 -enable-kvm with 320M memory
> 
> caused below changes:

So one driver skips drm_mode_config_init() and so
drm_connector_register_all() dies on the mutex_lock().

Maybe

	if (list_empty_safe(&dev->mode_config.connector_list))
		return;

or we could add a boolean to indicate an active mode_config?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

[toc] | [next] | [standalone]

#1425533 — Re: [drm] e28cd4d0a2: INFO: trying to register non-static key.

On Sat, Jun 18, 2016 at 12:19 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Sat, Jun 18, 2016 at 05:24:30AM +0800, kernel test robot wrote:
>>
>>
>> FYI, we noticed the following commit:
>>
>> git://anongit.freedesktop.org/drm-intel topic/drm-misc
>> commit e28cd4d0a223e1bcea616326e2281900e7e7e9a2 ("drm: Automatically register/unregister all connectors")
>>
>>
>> on test machine: vm-lkp-wsx03-yocto-i386: 1 threads qemu-system-i386 -enable-kvm with 320M memory
>>
>> caused below changes:
>
> So one driver skips drm_mode_config_init() and so
> drm_connector_register_all() dies on the mutex_lock().
>
> Maybe
>
>         if (list_empty_safe(&dev->mode_config.connector_list))
>                 return;
>
> or we could add a boolean to indicate an active mode_config?

list_empty_safe seems to be the simplest solution, I'd go with that one.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web