Re: [drm] e28cd4d0a2: INFO: trying to register non-static key.

From	Daniel Vetter <daniel.vetter@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [drm] e28cd4d0a2: INFO: trying to register non-static key.
Date	2016-06-18 00:50 +0200
Message-ID	<rLaKm-47q-7@gated-at.bofh.it> (permalink)
References	<rL9uV-3qd-5@gated-at.bofh.it> <rLahj-3W9-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jun 18, 2016 at 12:19 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Sat, Jun 18, 2016 at 05:24:30AM +0800, kernel test robot wrote:
>>
>>
>> FYI, we noticed the following commit:
>>
>> git://anongit.freedesktop.org/drm-intel topic/drm-misc
>> commit e28cd4d0a223e1bcea616326e2281900e7e7e9a2 ("drm: Automatically register/unregister all connectors")
>>
>>
>> on test machine: vm-lkp-wsx03-yocto-i386: 1 threads qemu-system-i386 -enable-kvm with 320M memory
>>
>> caused below changes:
>
> So one driver skips drm_mode_config_init() and so
> drm_connector_register_all() dies on the mutex_lock().
>
> Maybe
>
>         if (list_empty_safe(&dev->mode_config.connector_list))
>                 return;
>
> or we could add a boolean to indicate an active mode_config?

list_empty_safe seems to be the simplest solution, I'd go with that one.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [drm]  e28cd4d0a2: INFO: trying to register non-static key. Chris Wilson <chris@chris-wilson.co.uk> - 2016-06-18 00:20 +0200
  Re: [drm] e28cd4d0a2: INFO: trying to register non-static key. Daniel Vetter <daniel.vetter@ffwll.ch> - 2016-06-18 00:50 +0200

csiph-web