Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425464 > unrolled thread
| Started by | Jiri Kosina <jikos@kernel.org> |
|---|---|
| First post | 2016-06-17 22:50 +0200 |
| Last post | 2016-06-17 23:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer Jiri Kosina <jikos@kernel.org> - 2016-06-17 22:50 +0200
Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-06-17 23:10 +0200
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2016-06-17 22:50 +0200 |
| Subject | Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer |
| Message-ID | <rL8Sd-2Y1-9@gated-at.bofh.it> |
On Fri, 17 Jun 2016, Jiri Kosina wrote:
> > +struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
> > + uuid_le uuid, char *name)
> > +{
>
> Should be static.
Actually, going deeper into the code and trying to untangle all the
dependencies, there are quite a few more in other ipc.c, hid-client.c,
etc. Please fix that globally in the next iteration.
Thanks,
--
Jiri Kosina
SUSE Labs
[toc] | [next] | [standalone]
| From | Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> |
|---|---|
| Date | 2016-06-17 23:10 +0200 |
| Message-ID | <rL9bz-3jz-1@gated-at.bofh.it> |
| In reply to | #1425464 |
On Fri, 2016-06-17 at 22:45 +0200, Jiri Kosina wrote:
> On Fri, 17 Jun 2016, Jiri Kosina wrote:
>
> > > +struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device
> *dev,
> > > + uuid_le uuid, char
> *name)
> > > +{
> >
> > Should be static.
>
> Actually, going deeper into the code and trying to untangle all the
> dependencies, there are quite a few more in other ipc.c, hid-
> client.c,
> etc. Please fix that globally in the next iteration.
>
Great. I ran sparse and identified few more. I will fix this is new
iteration.
One thing I am still wondering is that the current ISH model is built
in only. Some distros configure CONFIG_HID as module. So in Kconfig in
drivers/hid/intel-ish-hid/, I need to add "select HID".
What do you think about this?
Unless you are in middle of review, I want to go ahead and send v2.
Thanks,
Srinivas
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web