Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer
Date	2016-06-17 22:50 +0200
Message-ID	<rL8Sd-2Y1-9@gated-at.bofh.it> (permalink)
References	<rIQ3n-2Yh-3@gated-at.bofh.it> <rIQ3n-2Yh-1@gated-at.bofh.it> <rL8Sd-2Y1-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 17 Jun 2016, Jiri Kosina wrote:

> > +struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
> > +					     uuid_le uuid, char *name)
> > +{
> 
> Should be static.

Actually, going deeper into the code and trying to untangle all the 
dependencies, there are quite a few more in other ipc.c, hid-client.c, 
etc. Please fix that globally in the next iteration.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer Jiri Kosina <jikos@kernel.org> - 2016-06-17 22:50 +0200
  Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-06-17 23:10 +0200

csiph-web