Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424373 > unrolled thread

[PATCH] snd: soc: cx20442 codec: set tty->receiver_room in v253_open

Back to article view | Back to linux.kernel

Contents

  [PATCH] snd: soc: cx20442 codec: set tty->receiver_room in v253_open Janusz Krzysztofik <jmkrzyszt@gmail.com> - 2016-06-16 22:10 +0200
    Re: [PATCH] snd: soc: cx20442 codec: set tty->receiver_room in  v253_open Mark Brown <broonie@kernel.org> - 2016-06-17 13:50 +0200
    Applied "ASoC: cx20442: set tty->receiver_room in v253_open" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-06-17 13:50 +0200

#1424373 — [PATCH] snd: soc: cx20442 codec: set tty->receiver_room in v253_open

Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"),
introduced in v3.10, revealed a bug in the cx20442 codec driver
which has never been setting tty->receive_room on line discipline
open as it should from the beginning. Fix it.

Created and tested on Amstrad Delta against Linux-4.7-rc3

Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
---
 sound/soc/codecs/cx20442.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c
index d6f4abb..fb3885f 100644
--- a/sound/soc/codecs/cx20442.c
+++ b/sound/soc/codecs/cx20442.c
@@ -226,6 +226,7 @@ static int v253_open(struct tty_struct *tty)
 	if (!tty->disc_data)
 		return -ENODEV;
 
+	tty->receive_room = 16;
 	if (tty->ops->write(tty, v253_init, len) != len) {
 		ret = -EIO;
 		goto err;
-- 
2.7.3

[toc] | [next] | [standalone]

#1424965 — Re: [PATCH] snd: soc: cx20442 codec: set tty->receiver_room in v253_open

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jun 16, 2016 at 10:04:35PM +0200, Janusz Krzysztofik wrote:
> Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"),
> introduced in v3.10, revealed a bug in the cx20442 codec driver
> which has never been setting tty->receive_room on line discipline
> open as it should from the beginning. Fix it.

Please submit patches using subject lines reflecting the style for the
subsystem.  This makes it easier for people to identify relevant
patches.

[toc] | [prev] | [next] | [standalone]

#1424969 — Applied "ASoC: cx20442: set tty->receiver_room in v253_open" to the asoc tree

The patch

   ASoC: cx20442: set tty->receiver_room in v253_open

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 86c0ae7cde7a8699116b365a5e3016753f0cd92a Mon Sep 17 00:00:00 2001
From: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Date: Thu, 16 Jun 2016 22:04:35 +0200
Subject: [PATCH] ASoC: cx20442: set tty->receiver_room in v253_open

Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"),
introduced in v3.10, revealed a bug in the cx20442 codec driver
which has never been setting tty->receive_room on line discipline
open as it should from the beginning. Fix it.

Created and tested on Amstrad Delta against Linux-4.7-rc3

Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/cx20442.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c
index d6f4abbbf8a7..fb3885fe0afb 100644
--- a/sound/soc/codecs/cx20442.c
+++ b/sound/soc/codecs/cx20442.c
@@ -226,6 +226,7 @@ static int v253_open(struct tty_struct *tty)
 	if (!tty->disc_data)
 		return -ENODEV;
 
+	tty->receive_room = 16;
 	if (tty->ops->write(tty, v253_init, len) != len) {
 		ret = -EIO;
 		goto err;
-- 
2.8.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web