[PATCH] snd: soc: cx20442 codec: set tty->receiver_room in v253_open

From	Janusz Krzysztofik <jmkrzyszt@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] snd: soc: cx20442 codec: set tty->receiver_room in v253_open
Date	2016-06-16 22:10 +0200
Message-ID	<rKLLX-4lm-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"),
introduced in v3.10, revealed a bug in the cx20442 codec driver
which has never been setting tty->receive_room on line discipline
open as it should from the beginning. Fix it.

Created and tested on Amstrad Delta against Linux-4.7-rc3

Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
---
 sound/soc/codecs/cx20442.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c
index d6f4abb..fb3885f 100644
--- a/sound/soc/codecs/cx20442.c
+++ b/sound/soc/codecs/cx20442.c
@@ -226,6 +226,7 @@ static int v253_open(struct tty_struct *tty)
 	if (!tty->disc_data)
 		return -ENODEV;
 
+	tty->receive_room = 16;
 	if (tty->ops->write(tty, v253_init, len) != len) {
 		ret = -EIO;
 		goto err;
-- 
2.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] snd: soc: cx20442 codec: set tty->receiver_room in v253_open Janusz Krzysztofik <jmkrzyszt@gmail.com> - 2016-06-16 22:10 +0200
  Re: [PATCH] snd: soc: cx20442 codec: set tty->receiver_room in  v253_open Mark Brown <broonie@kernel.org> - 2016-06-17 13:50 +0200
  Applied "ASoC: cx20442: set tty->receiver_room in v253_open" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-06-17 13:50 +0200

csiph-web