Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1420414 > unrolled thread

Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

Started byChen-Yu Tsai <wens@csie.org>
First post2016-06-13 05:10 +0200
Last post2016-06-16 05:10 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Chen-Yu Tsai <wens@csie.org> - 2016-06-13 05:10 +0200
    Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-15 23:00 +0200
      Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Chen-Yu Tsai <wens@csie.org> - 2016-06-16 05:10 +0200

#1420414 — Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

FromChen-Yu Tsai <wens@csie.org>
Date2016-06-13 05:10 +0200
SubjectRe: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Message-ID<rJqqd-x5-1@gated-at.bofh.it>
On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
>> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
>> >[...]
>> >Yes, everything that is shared with the banana-pro (which, judging
>> >from Bernhard, is pretty much everything but a GPIO) should be merged
>> >in the banapro DT.
>> >
>> >Maxime
>> >
>>
>> Don't take my word for granted, as I do not own this hardware or know it
>> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
>> very similar, but if in doubt the information form the wiki should be
>> verified.
>
> Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
> more than I do.

I did a comparison of the "Banana Pro" vs the "BPi-M1+".

The differences are similar to what we have with any other development
board, say the Cubietruck:

  - A different WiFi chip is used, and the BT part is not hooked up.
  - Different GPIOs for external power regulator/switches
  - Different GPIOs for LEDs
  - Different peripherals exposed on the headers.

IMO There's no need to merge or have a common .dtsi for the two boards.
They (and all the other development boards) look similar because
everyone is following the basic set by Allwinner's reference design,
like which MMC controller and pins are used for SD/MMC, which ones
are used for SDIO-based WiFi, and so on.

I did a version completely from scratch using just the schematics:

  https://github.com/wens/linux/commits/bpi-m1-plus

Please ignore the last commit. It's just me playing with NTP support
for GPS time.


Regards
ChenYu

[toc] | [next] | [standalone]


#1423445

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-06-15 23:00 +0200
Message-ID<rKq4O-7mg-11@gated-at.bofh.it>
In reply to#1420414

[Multipart message — attachments visible in raw view] — view raw

Hi Chen-Yu,

On Mon, Jun 13, 2016 at 11:01:53AM +0800, Chen-Yu Tsai wrote:
> On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
> >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> >> >[...]
> >> >Yes, everything that is shared with the banana-pro (which, judging
> >> >from Bernhard, is pretty much everything but a GPIO) should be merged
> >> >in the banapro DT.
> >> >
> >> >Maxime
> >> >
> >>
> >> Don't take my word for granted, as I do not own this hardware or know it
> >> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
> >> very similar, but if in doubt the information form the wiki should be
> >> verified.
> >
> > Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
> > more than I do.
> 
> I did a comparison of the "Banana Pro" vs the "BPi-M1+".
> 
> The differences are similar to what we have with any other development
> board, say the Cubietruck:
> 
>   - A different WiFi chip is used, and the BT part is not hooked up.
>   - Different GPIOs for external power regulator/switches
>   - Different GPIOs for LEDs
>   - Different peripherals exposed on the headers.
> 
> IMO There's no need to merge or have a common .dtsi for the two boards.

Ok.

> They (and all the other development boards) look similar because
> everyone is following the basic set by Allwinner's reference design,
> like which MMC controller and pins are used for SD/MMC, which ones
> are used for SDIO-based WiFi, and so on.
> 
> I did a version completely from scratch using just the schematics:
> 
>   https://github.com/wens/linux/commits/bpi-m1-plus

So, what do you mean by that? Do you have some comments on that patch,
or should I merge it, and you'll post your additions on top of it?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]


#1423656

FromChen-Yu Tsai <wens@csie.org>
Date2016-06-16 05:10 +0200
Message-ID<rKvQS-2Uh-5@gated-at.bofh.it>
In reply to#1423445
On Thu, Jun 16, 2016 at 4:52 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi Chen-Yu,
>
> On Mon, Jun 13, 2016 at 11:01:53AM +0800, Chen-Yu Tsai wrote:
>> On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
>> >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
>> >> >[...]
>> >> >Yes, everything that is shared with the banana-pro (which, judging
>> >> >from Bernhard, is pretty much everything but a GPIO) should be merged
>> >> >in the banapro DT.
>> >> >
>> >> >Maxime
>> >> >
>> >>
>> >> Don't take my word for granted, as I do not own this hardware or know it
>> >> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
>> >> very similar, but if in doubt the information form the wiki should be
>> >> verified.
>> >
>> > Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
>> > more than I do.
>>
>> I did a comparison of the "Banana Pro" vs the "BPi-M1+".
>>
>> The differences are similar to what we have with any other development
>> board, say the Cubietruck:
>>
>>   - A different WiFi chip is used, and the BT part is not hooked up.
>>   - Different GPIOs for external power regulator/switches
>>   - Different GPIOs for LEDs
>>   - Different peripherals exposed on the headers.
>>
>> IMO There's no need to merge or have a common .dtsi for the two boards.
>
> Ok.
>
>> They (and all the other development boards) look similar because
>> everyone is following the basic set by Allwinner's reference design,
>> like which MMC controller and pins are used for SD/MMC, which ones
>> are used for SDIO-based WiFi, and so on.
>>
>> I did a version completely from scratch using just the schematics:
>>
>>   https://github.com/wens/linux/commits/bpi-m1-plus
>
> So, what do you mean by that? Do you have some comments on that patch,
> or should I merge it, and you'll post your additions on top of it?

I'd like Luo to send a new version, based on what was his updated v1.

I'll reply to that one with some comments.


ChenYu

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web