Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1422859 > unrolled thread
| Started by | Andreas Ziegler <andreas.ziegler@fau.de> |
|---|---|
| First post | 2016-06-15 12:10 +0200 |
| Last post | 2016-06-15 16:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
select on non-existing Kconfig option CRC32C Andreas Ziegler <andreas.ziegler@fau.de> - 2016-06-15 12:10 +0200
Re: select on non-existing Kconfig option CRC32C Hendrik Brueckner <brueckner@linux.vnet.ibm.com> - 2016-06-15 16:50 +0200
Re: select on non-existing Kconfig option CRC32C Randy Dunlap <rdunlap@infradead.org> - 2016-06-15 16:50 +0200
| From | Andreas Ziegler <andreas.ziegler@fau.de> |
|---|---|
| Date | 2016-06-15 12:10 +0200 |
| Subject | select on non-existing Kconfig option CRC32C |
| Message-ID | <rKfVM-1co-19@gated-at.bofh.it> |
Hi Hendrik, your patch "s390/crc32-vx: add crypto API module for optimized CRC-32 algorithms" showed up in linux-next today (next-20160615) as commit 364148e0b195. The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C. However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist. Should I prepare a trivial patch to fix this up or would you like to do that on your side? I found this issue by comparing yesterday's tree and today's tree using 'scripts/checkkconfigsymbols -f -d next-20160614..next-20160615'. Best regards, Andreas
[toc] | [next] | [standalone]
| From | Hendrik Brueckner <brueckner@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-06-15 16:50 +0200 |
| Message-ID | <rKkiK-3Lp-7@gated-at.bofh.it> |
| In reply to | #1422859 |
Hi Andreas, On Wed, Jun 15, 2016 at 12:00:59PM +0200, Andreas Ziegler wrote: > > your patch "s390/crc32-vx: add crypto API module for optimized CRC-32 > algorithms" showed up in linux-next today (next-20160615) as commit 364148e0b195. > > The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C. > However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist. Thanks for informing me. Actually, the crc32-vx driver requires the __crc32c_le() function which is available by selecting CONFIG_CRC32. There is no need for CRYPTO_CRC32C. So this can be safely removed. > Should I prepare a trivial patch to fix this up or would you like to do that on > your side? Martin have already corrected the patch. Thanks and kind regards, Hendrik
[toc] | [prev] | [next] | [standalone]
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2016-06-15 16:50 +0200 |
| Message-ID | <rKkiK-3Lp-5@gated-at.bofh.it> |
| In reply to | #1422859 |
On 06/15/16 03:00, Andreas Ziegler wrote: > Hi Hendrik, > > your patch "s390/crc32-vx: add crypto API module for optimized CRC-32 > algorithms" showed up in linux-next today (next-20160615) as commit 364148e0b195. > > The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C. > However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist. > Should I prepare a trivial patch to fix this up or would you like to do that on > your side? > > I found this issue by comparing yesterday's tree and today's tree using > 'scripts/checkkconfigsymbols -f -d next-20160614..next-20160615'. or should it select CRC32 or LIBCRC32C? (probably not the LIB... one) -- ~Randy
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web