Re: select on non-existing Kconfig option CRC32C

From	Randy Dunlap <rdunlap@infradead.org>
Newsgroups	linux.kernel
Subject	Re: select on non-existing Kconfig option CRC32C
Date	2016-06-15 16:50 +0200
Message-ID	<rKkiK-3Lp-5@gated-at.bofh.it> (permalink)
References	<rKfVM-1co-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/15/16 03:00, Andreas Ziegler wrote:
> Hi Hendrik,
> 
> your patch "s390/crc32-vx: add crypto API module for optimized CRC-32
> algorithms" showed up in linux-next today (next-20160615) as commit 	364148e0b195.
> 
> The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C.
> However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist.
> Should I prepare a trivial patch to fix this up or would you like to do that on
> your side?
> 
> I found this issue by comparing yesterday's tree and today's tree using
> 'scripts/checkkconfigsymbols -f -d next-20160614..next-20160615'.

or should it select CRC32 or LIBCRC32C?  (probably not the LIB... one)

-- 
~Randy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

select on non-existing Kconfig option CRC32C Andreas Ziegler <andreas.ziegler@fau.de> - 2016-06-15 12:10 +0200
  Re: select on non-existing Kconfig option CRC32C Hendrik Brueckner <brueckner@linux.vnet.ibm.com> - 2016-06-15 16:50 +0200
  Re: select on non-existing Kconfig option CRC32C Randy Dunlap <rdunlap@infradead.org> - 2016-06-15 16:50 +0200

csiph-web