Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1424852 > unrolled thread
| Started by | Ganesh Mahendran <opensource.ganesh@gmail.com> |
|---|---|
| First post | 2016-06-17 11:40 +0200 |
| Last post | 2016-06-17 12:00 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] mm/compaction: remove local variable is_lru Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-17 11:40 +0200
Re: [PATCH] mm/compaction: remove local variable is_lru Michal Hocko <mhocko@kernel.org> - 2016-06-17 12:00 +0200
Re: [PATCH] mm/compaction: remove local variable is_lru Vlastimil Babka <vbabka@suse.cz> - 2016-06-17 15:00 +0200
Re: [PATCH] mm/compaction: remove local variable is_lru "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-06-17 12:00 +0200
| From | Ganesh Mahendran <opensource.ganesh@gmail.com> |
|---|---|
| Date | 2016-06-17 11:40 +0200 |
| Subject | [PATCH] mm/compaction: remove local variable is_lru |
| Message-ID | <rKYpQ-4Lt-11@gated-at.bofh.it> |
local varialbe is_lru was used for tracking non-lru pages(such as
balloon pages).
But commit
112ea7b668d3 ("mm: migrate: support non-lru movable page migration")
introduced a common framework for non-lru page migration and moved
the compound pages check before non-lru movable pages check.
So there is no need to use local variable is_lru.
Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
---
mm/compaction.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index fbb7b38..780be7f 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -724,7 +724,6 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
/* Time to isolate some pages for migration */
for (; low_pfn < end_pfn; low_pfn++) {
- bool is_lru;
if (skip_on_failure && low_pfn >= next_skip_pfn) {
/*
@@ -807,8 +806,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
* It's possible to migrate LRU and non-lru movable pages.
* Skip any other type of page
*/
- is_lru = PageLRU(page);
- if (!is_lru) {
+ if (!PageLRU(page)) {
/*
* __PageMovable can return false positive so we need
* to verify it under page_lock.
--
1.9.1
[toc] | [next] | [standalone]
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Date | 2016-06-17 12:00 +0200 |
| Message-ID | <rKYJc-4U2-9@gated-at.bofh.it> |
| In reply to | #1424852 |
On Fri 17-06-16 17:32:51, Ganesh Mahendran wrote:
> local varialbe is_lru was used for tracking non-lru pages(such as
> balloon pages).
>
> But commit
> 112ea7b668d3 ("mm: migrate: support non-lru movable page migration")
this commit sha is not stable because it is from the linux-next tree.
> introduced a common framework for non-lru page migration and moved
> the compound pages check before non-lru movable pages check.
>
> So there is no need to use local variable is_lru.
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
Other than that the patch looks ok and maybe it would be worth folding
into the mm-migrate-support-non-lru-movable-page-migration.patch
> ---
> mm/compaction.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index fbb7b38..780be7f 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -724,7 +724,6 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
>
> /* Time to isolate some pages for migration */
> for (; low_pfn < end_pfn; low_pfn++) {
> - bool is_lru;
>
> if (skip_on_failure && low_pfn >= next_skip_pfn) {
> /*
> @@ -807,8 +806,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
> * It's possible to migrate LRU and non-lru movable pages.
> * Skip any other type of page
> */
> - is_lru = PageLRU(page);
> - if (!is_lru) {
> + if (!PageLRU(page)) {
> /*
> * __PageMovable can return false positive so we need
> * to verify it under page_lock.
> --
> 1.9.1
>
--
Michal Hocko
SUSE Labs
[toc] | [prev] | [next] | [standalone]
| From | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| Date | 2016-06-17 15:00 +0200 |
| Message-ID | <rL1xo-6DO-11@gated-at.bofh.it> |
| In reply to | #1424866 |
On 06/17/2016 11:50 AM, Michal Hocko wrote:
> On Fri 17-06-16 17:32:51, Ganesh Mahendran wrote:
>> local varialbe is_lru was used for tracking non-lru pages(such as
>> balloon pages).
>>
>> But commit
>> 112ea7b668d3 ("mm: migrate: support non-lru movable page migration")
>
> this commit sha is not stable because it is from the linux-next tree.
>
>> introduced a common framework for non-lru page migration and moved
>> the compound pages check before non-lru movable pages check.
>>
>> So there is no need to use local variable is_lru.
>>
>> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
>
> Other than that the patch looks ok and maybe it would be worth folding
> into the mm-migrate-support-non-lru-movable-page-migration.patch
Agreed.
[toc] | [prev] | [next] | [standalone]
| From | "Hillf Danton" <hillf.zj@alibaba-inc.com> |
|---|---|
| Date | 2016-06-17 12:00 +0200 |
| Message-ID | <rKYJc-4U2-11@gated-at.bofh.it> |
| In reply to | #1424852 |
>
> local varialbe is_lru was used for tracking non-lru pages(such as
> balloon pages).
>
> But commit
> 112ea7b668d3 ("mm: migrate: support non-lru movable page migration")
> introduced a common framework for non-lru page migration and moved
> the compound pages check before non-lru movable pages check.
>
> So there is no need to use local variable is_lru.
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> mm/compaction.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index fbb7b38..780be7f 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -724,7 +724,6 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
>
> /* Time to isolate some pages for migration */
> for (; low_pfn < end_pfn; low_pfn++) {
> - bool is_lru;
>
> if (skip_on_failure && low_pfn >= next_skip_pfn) {
> /*
> @@ -807,8 +806,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
> * It's possible to migrate LRU and non-lru movable pages.
> * Skip any other type of page
> */
> - is_lru = PageLRU(page);
> - if (!is_lru) {
> + if (!PageLRU(page)) {
> /*
> * __PageMovable can return false positive so we need
> * to verify it under page_lock.
> --
> 1.9.1
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web