Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425047
| From | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mm/compaction: remove local variable is_lru |
| Date | 2016-06-17 15:00 +0200 |
| Message-ID | <rL1xo-6DO-11@gated-at.bofh.it> (permalink) |
| References | <rKYpQ-4Lt-11@gated-at.bofh.it> <rKYJc-4U2-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/17/2016 11:50 AM, Michal Hocko wrote:
> On Fri 17-06-16 17:32:51, Ganesh Mahendran wrote:
>> local varialbe is_lru was used for tracking non-lru pages(such as
>> balloon pages).
>>
>> But commit
>> 112ea7b668d3 ("mm: migrate: support non-lru movable page migration")
>
> this commit sha is not stable because it is from the linux-next tree.
>
>> introduced a common framework for non-lru page migration and moved
>> the compound pages check before non-lru movable pages check.
>>
>> So there is no need to use local variable is_lru.
>>
>> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
>
> Other than that the patch looks ok and maybe it would be worth folding
> into the mm-migrate-support-non-lru-movable-page-migration.patch
Agreed.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mm/compaction: remove local variable is_lru Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-17 11:40 +0200
Re: [PATCH] mm/compaction: remove local variable is_lru Michal Hocko <mhocko@kernel.org> - 2016-06-17 12:00 +0200
Re: [PATCH] mm/compaction: remove local variable is_lru Vlastimil Babka <vbabka@suse.cz> - 2016-06-17 15:00 +0200
Re: [PATCH] mm/compaction: remove local variable is_lru "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-06-17 12:00 +0200
csiph-web