Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424585 > unrolled thread

[PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Started byJim Gill <jgill@vmware.com>
First post2016-06-17 03:20 +0200
Last post2016-06-21 04:10 +0200
Articles 14 — 6 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Jim Gill <jgill@vmware.com> - 2016-06-17 03:20 +0200
    Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Arvind Kumar <arvindkumar@vmware.com> - 2016-06-17 03:40 +0200
    Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Julian Calaby <julian.calaby@gmail.com> - 2016-06-17 03:50 +0200
      Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Arvind Kumar <arvindkumar@vmware.com> - 2016-06-17 04:10 +0200
        Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Julian Calaby <julian.calaby@gmail.com> - 2016-06-17 04:20 +0200
          Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Joe Perches <joe@perches.com> - 2016-06-17 04:40 +0200
            Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Julian Calaby <julian.calaby@gmail.com> - 2016-06-17 04:50 +0200
              Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Joe Perches <joe@perches.com> - 2016-06-17 05:10 +0200
                Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Julian Calaby <julian.calaby@gmail.com> - 2016-06-17 05:20 +0200
                  Re: [Pv-drivers] [PATCH] VMW_PVSCSI: Change to update maintainer  details (name, email) Thomas Hellstrom <thellstrom@vmware.com> - 2016-06-17 10:20 +0200
                  Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Jim Gill <jgill@vmware.com> - 2016-06-17 19:50 +0200
                    Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Joe Perches <joe@perches.com> - 2016-06-17 20:10 +0200
                      Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Jim Gill <jgill@vmware.com> - 2016-06-17 20:20 +0200
    Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-21 04:10 +0200

#1424585 — [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

FromJim Gill <jgill@vmware.com>
Date2016-06-17 03:20 +0200
Subject[PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Message-ID<rKQBX-87A-7@gated-at.bofh.it>
 From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill <jgill@vmware.com>
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Signed-off-by: Jim Gill <jgill@vmware.com>
---
  drivers/scsi/vmw_pvscsi.c | 2 +-
  drivers/scsi/vmw_pvscsi.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 6164634..4a0d3cd 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -17,7 +17,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
+ * Maintained by: Jim Gill <jgill@vmware.com>
   *
   */
  
diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmw_pvscsi.h
index 12712c9..c097d2c 100644
--- a/drivers/scsi/vmw_pvscsi.h
+++ b/drivers/scsi/vmw_pvscsi.h
@@ -17,7 +17,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
+ * Maintained by: Jim Gill <jgill@vmware.com>
   *
   */
  
-- 
2.5.0

[toc] | [next] | [standalone]

#1424593 — Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

FromArvind Kumar <arvindkumar@vmware.com>
Date2016-06-17 03:40 +0200
SubjectRe: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Message-ID<rKQVk-8e5-13@gated-at.bofh.it>
In reply to#1424585
Looks fine to me.

Acked-by: Arvind Kumar (arvindkumar@vmware.com)

Thanks!
Arvind
________________________________________
From: Jim Gill <jgill@vmware.com>
Sent: Thursday, June 16, 2016 6:05 PM
To: jejb@linux.vnet.ibm.com; martin.petersen@oracle.com
Cc: Arvind Kumar; pv-drivers@vmware.com; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

 From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill <jgill@vmware.com>
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Signed-off-by: Jim Gill <jgill@vmware.com>
---
  drivers/scsi/vmw_pvscsi.c | 2 +-
  drivers/scsi/vmw_pvscsi.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 6164634..4a0d3cd 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -17,7 +17,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
+ * Maintained by: Jim Gill <jgill@vmware.com>
   *
   */

diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmw_pvscsi.h
index 12712c9..c097d2c 100644
--- a/drivers/scsi/vmw_pvscsi.h
+++ b/drivers/scsi/vmw_pvscsi.h
@@ -17,7 +17,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
+ * Maintained by: Jim Gill <jgill@vmware.com>
   *
   */

--
2.5.0

[toc] | [prev] | [next] | [standalone]

#1424599

FromJulian Calaby <julian.calaby@gmail.com>
Date2016-06-17 03:50 +0200
Message-ID<rKR50-8jh-11@gated-at.bofh.it>
In reply to#1424585
Hi Jim,

On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill <jgill@vmware.com> wrote:
> From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
> From: Jim Gill <jgill@vmware.com>
> Date: Thu, 16 Jun 2016 14:10:43 -0700
> Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,
> email)
>
> Signed-off-by: Jim Gill <jgill@vmware.com>
> ---
>  drivers/scsi/vmw_pvscsi.c | 2 +-
>  drivers/scsi/vmw_pvscsi.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
> index 6164634..4a0d3cd 100644
> --- a/drivers/scsi/vmw_pvscsi.c
> +++ b/drivers/scsi/vmw_pvscsi.c
> @@ -17,7 +17,7 @@
>   * along with this program; if not, write to the Free Software
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
> USA.
>   *
> - * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
> + * Maintained by: Jim Gill <jgill@vmware.com>

Shouldn't you update MAINTAINERs too? And isn't having this
information in these files redundant?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

[toc] | [prev] | [next] | [standalone]

#1424607 — Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

FromArvind Kumar <arvindkumar@vmware.com>
Date2016-06-17 04:10 +0200
SubjectRe: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Message-ID<rKRol-eV-1@gated-at.bofh.it>
In reply to#1424599
Hi Julian,

Thanks for spotting that. We will update that too.

I don't really see it as redundant rather as a quick reference instead of digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. Specially for those readers who might not even know about the MAINTAINERS file.

Thanks!
Arvind
________________________________________
From: Julian Calaby <julian.calaby@gmail.com>
Sent: Thursday, June 16, 2016 6:48 PM
To: Jim Gill
Cc: jejb@linux.vnet.ibm.com; Martin K. Petersen; Arvind Kumar; pv-drivers@vmware.com; linux-scsi; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Hi Jim,

On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill <jgill@vmware.com> wrote:
> From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
> From: Jim Gill <jgill@vmware.com>
> Date: Thu, 16 Jun 2016 14:10:43 -0700
> Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,
> email)
>
> Signed-off-by: Jim Gill <jgill@vmware.com>
> ---
>  drivers/scsi/vmw_pvscsi.c | 2 +-
>  drivers/scsi/vmw_pvscsi.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
> index 6164634..4a0d3cd 100644
> --- a/drivers/scsi/vmw_pvscsi.c
> +++ b/drivers/scsi/vmw_pvscsi.c
> @@ -17,7 +17,7 @@
>   * along with this program; if not, write to the Free Software
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
> USA.
>   *
> - * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
> + * Maintained by: Jim Gill <jgill@vmware.com>

Shouldn't you update MAINTAINERs too? And isn't having this
information in these files redundant?

Thanks,

--
Julian Calaby

Email: julian.calaby@gmail.com
Profile: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.google.com_profiles_julian.calaby_&d=CwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=bUMaNc7nC9xbXtaMJrOvIIPNpPH0chY2kdRsskQn6GY&m=JibRIMgSBQLffjc5PofQnpJ0k_gawmvafvIKpsEaMzk&s=CeVpY1FwvY9Qlb0VDeQUXeeL3kuVkcIKTZIC7exS6SM&e=

[toc] | [prev] | [next] | [standalone]

#1424608

FromJulian Calaby <julian.calaby@gmail.com>
Date2016-06-17 04:20 +0200
Message-ID<rKRy1-ov-1@gated-at.bofh.it>
In reply to#1424607
Hi Arvind,

On Fri, Jun 17, 2016 at 12:03 PM, Arvind Kumar <arvindkumar@vmware.com> wrote:
> Hi Julian,
>
> Thanks for spotting that. We will update that too.
>
> I don't really see it as redundant rather as a quick reference instead of digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. Specially for those readers who might not even know about the MAINTAINERS file.

You can use the get_maintainers script in the scripts directory to
quickly get information from MAINTAINERS, i.e.:

./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c

or

./scripts/get_maintainers.pl patchfile.patch

Thanks,

Julian Calaby


>
> Thanks!
> Arvind
> ________________________________________
> From: Julian Calaby <julian.calaby@gmail.com>
> Sent: Thursday, June 16, 2016 6:48 PM
> To: Jim Gill
> Cc: jejb@linux.vnet.ibm.com; Martin K. Petersen; Arvind Kumar; pv-drivers@vmware.com; linux-scsi; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
>
> Hi Jim,
>
> On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill <jgill@vmware.com> wrote:
>> From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
>> From: Jim Gill <jgill@vmware.com>
>> Date: Thu, 16 Jun 2016 14:10:43 -0700
>> Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,
>> email)
>>
>> Signed-off-by: Jim Gill <jgill@vmware.com>
>> ---
>>  drivers/scsi/vmw_pvscsi.c | 2 +-
>>  drivers/scsi/vmw_pvscsi.h | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
>> index 6164634..4a0d3cd 100644
>> --- a/drivers/scsi/vmw_pvscsi.c
>> +++ b/drivers/scsi/vmw_pvscsi.c
>> @@ -17,7 +17,7 @@
>>   * along with this program; if not, write to the Free Software
>>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
>> USA.
>>   *
>> - * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
>> + * Maintained by: Jim Gill <jgill@vmware.com>
>
> Shouldn't you update MAINTAINERs too? And isn't having this
> information in these files redundant?
>
> Thanks,
>
> --
> Julian Calaby
>
> Email: julian.calaby@gmail.com
> Profile: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.google.com_profiles_julian.calaby_&d=CwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=bUMaNc7nC9xbXtaMJrOvIIPNpPH0chY2kdRsskQn6GY&m=JibRIMgSBQLffjc5PofQnpJ0k_gawmvafvIKpsEaMzk&s=CeVpY1FwvY9Qlb0VDeQUXeeL3kuVkcIKTZIC7exS6SM&e=



-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

[toc] | [prev] | [next] | [standalone]

#1424618 — Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

FromJoe Perches <joe@perches.com>
Date2016-06-17 04:40 +0200
SubjectRe: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Message-ID<rKRRo-uH-7@gated-at.bofh.it>
In reply to#1424608
On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote:
> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c

just fyi:  the script name is not plural

$ ./scripts/get_maintainer.pl  -f drivers/scsi/vmw_pvscsi.c
Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver)
VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
linux-kernel@vger.kernel.org (open list)

and another fyi:

get_maintainer.pl also has a rarely used "--file-emails" option to
scan for what appears to be email addresses in specific files.

$ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
linux-kernel@vger.kernel.org (open list)

note the "in file" after Arvind's name

[toc] | [prev] | [next] | [standalone]

#1424620

FromJulian Calaby <julian.calaby@gmail.com>
Date2016-06-17 04:50 +0200
Message-ID<rKS13-xY-7@gated-at.bofh.it>
In reply to#1424618
Hi Joe,

On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote:
>> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c
>
> just fyi:  the script name is not plural

Thanks, must have typo'd it between running it and typing it into the email.

> $ ./scripts/get_maintainer.pl  -f drivers/scsi/vmw_pvscsi.c
> Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver)
> VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
> "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
> linux-kernel@vger.kernel.org (open list)
>
> and another fyi:
>
> get_maintainer.pl also has a rarely used "--file-emails" option to
> scan for what appears to be email addresses in specific files.
>
> $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
> Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
> VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
> "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
> linux-kernel@vger.kernel.org (open list)
>
> note the "in file" after Arvind's name

Didn't know this, however my point stands: the maintainer line in the
file is redundant if we find maintainers through MAINTAINERS or the
get_maintainer.pl script.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

[toc] | [prev] | [next] | [standalone]

#1424623 — Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

FromJoe Perches <joe@perches.com>
Date2016-06-17 05:10 +0200
SubjectRe: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Message-ID<rKSkq-Vx-13@gated-at.bofh.it>
In reply to#1424620
On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
> Hi Joe,

rehi Julian.

> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
[]
> > get_maintainer.pl also has a rarely used "--file-emails" option to
> > scan for what appears to be email addresses in specific files.
> > 
> > $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
> > Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
> > VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
> > "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
> > "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
> > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
> > linux-kernel@vger.kernel.org (open list)
> > 
> > note the "in file" after Arvind's name
> Didn't know this, however my point stands: the maintainer line in the
> file is redundant if we find maintainers through MAINTAINERS or the
> get_maintainer.pl script.

Yes, I'm not suggesting anything else.  Jim's name
should appear in the MAINTAINERS file somewhere.

The question to me is whether or not Jim Gill is
taking over the maintainership of the entire
VMware PVSCSI driver or just a few files of it.

[toc] | [prev] | [next] | [standalone]

#1424627

FromJulian Calaby <julian.calaby@gmail.com>
Date2016-06-17 05:20 +0200
Message-ID<rKSu5-138-5@gated-at.bofh.it>
In reply to#1424623
Hi Joe,

On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
>> Hi Joe,
>
> rehi Julian.

(I always put a salutation on my emails and always finish them with
"Thanks," =) )

>> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
> []
>> > get_maintainer.pl also has a rarely used "--file-emails" option to
>> > scan for what appears to be email addresses in specific files.
>> >
>> > $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
>> > Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
>> > VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
>> > "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
>> > "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
>> > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
>> > linux-kernel@vger.kernel.org (open list)
>> >
>> > note the "in file" after Arvind's name
>> Didn't know this, however my point stands: the maintainer line in the
>> file is redundant if we find maintainers through MAINTAINERS or the
>> get_maintainer.pl script.
>
> Yes, I'm not suggesting anything else.  Jim's name
> should appear in the MAINTAINERS file somewhere.
>
> The question to me is whether or not Jim Gill is
> taking over the maintainership of the entire
> VMware PVSCSI driver or just a few files of it.

As I see it, he's taking over maintainership of all of it: it's only
files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

[toc] | [prev] | [next] | [standalone]

#1424794 — Re: [Pv-drivers] [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

FromThomas Hellstrom <thellstrom@vmware.com>
Date2016-06-17 10:20 +0200
SubjectRe: [Pv-drivers] [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Message-ID<rKXap-43m-3@gated-at.bofh.it>
In reply to#1424627
Hi!

IMO we shouldn't have maintainer info mentioned in the source files,
since the information is redundant and moreover if we change maintainer
a patch touching multiple files would just look odd, and we'd leave a
lot of stale info in older kernels.

Having the linux git *master* MAINTAINERS file as the authoritative
information source for this makes most sense. If there are different
maintainers of different parts of a single module we should be able to
sort that out internally.

Thanks,
Thomas



On 06/17/2016 05:11 AM, Julian Calaby wrote:
> Hi Joe,
>
> On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <joe@perches.com> wrote:
>> On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
>>> Hi Joe,
>> rehi Julian.
> (I always put a salutation on my emails and always finish them with
> "Thanks," =) )
>
>>> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
>> []
>>>> get_maintainer.pl also has a rarely used "--file-emails" option to
>>>> scan for what appears to be email addresses in specific files.
>>>>
>>>> $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
>>>> Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
>>>> VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
>>>> "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
>>>> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
>>>> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
>>>> linux-kernel@vger.kernel.org (open list)
>>>>
>>>> note the "in file" after Arvind's name
>>> Didn't know this, however my point stands: the maintainer line in the
>>> file is redundant if we find maintainers through MAINTAINERS or the
>>> get_maintainer.pl script.
>> Yes, I'm not suggesting anything else.  Jim's name
>> should appear in the MAINTAINERS file somewhere.
>>
>> The question to me is whether or not Jim Gill is
>> taking over the maintainership of the entire
>> VMware PVSCSI driver or just a few files of it.
> As I see it, he's taking over maintainership of all of it: it's only
> files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.
>
> Thanks,
>

[toc] | [prev] | [next] | [standalone]

#1425355 — Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

FromJim Gill <jgill@vmware.com>
Date2016-06-17 19:50 +0200
SubjectRe: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Message-ID<rL641-15V-7@gated-at.bofh.it>
In reply to#1424627
On 6/16/16, 8:11 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote:



>[]
>
>>>On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
>> []
>>The question to me is whether or not Jim Gill is
>> taking over the maintainership of the entire
>> VMware PVSCSI driver or just a few files of it.
>
>As I see it, he's taking over maintainership of all of it: it's only
>files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.

This is correct, I am taking over maintainership of the entire vmw_pvscsi driver.

[toc] | [prev] | [next] | [standalone]

#1425366 — Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

FromJoe Perches <joe@perches.com>
Date2016-06-17 20:10 +0200
SubjectRe: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Message-ID<rL6no-1tv-7@gated-at.bofh.it>
In reply to#1425355
On Fri, 2016-06-17 at 17:44 +0000, Jim Gill wrote:
> On 6/16/16, 8:11 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote:
> 
> 
> 
> > 
> > []
> > 
> > > 
> > > > 
> > > > On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
> > > []
> > > The question to me is whether or not Jim Gill is
> > > taking over the maintainership of the entire
> > > VMware PVSCSI driver or just a few files of it.
> > As I see it, he's taking over maintainership of all of it: it's only
> > files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.
> This is correct, I am taking over maintainership of the entire vmw_pvscsi driver.

Perhaps a patch like this:

From e727c6549e3be466ec3c79e919502cb0b9909b03 Mon Sep 17 00:00:00 2001
Message-Id: <e727c6549e3be466ec3c79e919502cb0b9909b03.1466186573.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Fri, 17 Jun 2016 10:56:49 -0700
Subject: [PATCH] vmw_pvscsi: Move into separate directory, Jim Gill is MAINTAINER

Separate directories for drivers are generally better.

Miscellanea:

o Update the MAINTAINER entry
o Remove maintainer and FSF addresses from driver files
---
 MAINTAINERS                            | 5 ++---
 drivers/scsi/Kconfig                   | 8 +-------
 drivers/scsi/Makefile                  | 2 +-
 drivers/scsi/vmware/Kconfig            | 7 +++++++
 drivers/scsi/vmware/Makefile           | 1 +
 drivers/scsi/{ => vmware}/vmw_pvscsi.c | 7 -------
 drivers/scsi/{ => vmware}/vmw_pvscsi.h | 7 -------
 7 files changed, 12 insertions(+), 25 deletions(-)
 create mode 100644 drivers/scsi/vmware/Kconfig
 create mode 100644 drivers/scsi/vmware/Makefile
 rename drivers/scsi/{ => vmware}/vmw_pvscsi.c (99%)
 rename drivers/scsi/{ => vmware}/vmw_pvscsi.h (98%)

diff --git a/MAINTAINERS b/MAINTAINERS
index d174e34..2763582 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12421,12 +12421,11 @@ S:	Maintained
 F:	drivers/net/vmxnet3/
 
 VMware PVSCSI driver
-M:	Arvind Kumar <arvindkumar@vmware.com>
+M:	Jim Gill <jgill@vmware.com>
 M:	VMware PV-Drivers <pv-drivers@vmware.com>
 L:	linux-scsi@vger.kernel.org
 S:	Maintained
-F:	drivers/scsi/vmw_pvscsi.c
-F:	drivers/scsi/vmw_pvscsi.h
+F:	drivers/scsi/vmware/
 
 VOLTAGE AND CURRENT REGULATOR FRAMEWORK
 M:	Liam Girdwood <lgirdwood@gmail.com>
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 1918f54..339c230 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -576,13 +576,7 @@ config SCSI_FLASHPOINT
 	  substantial, so users of MultiMaster Host Adapters may not
 	  wish to include it.
 
-config VMWARE_PVSCSI
-	tristate "VMware PVSCSI driver support"
-	depends on PCI && SCSI && X86
-	help
-	  This driver supports VMware's para virtualized SCSI HBA.
-	  To compile this driver as a module, choose M here: the
-	  module will be called vmw_pvscsi.
+source "drivers/scsi/vmware/Kconfig"
 
 config XEN_SCSI_FRONTEND
 	tristate "XEN SCSI frontend driver"
diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 862ab4e..6cfefaa 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
@@ -141,7 +141,7 @@ obj-$(CONFIG_BE2ISCSI)		+= libiscsi.o be2iscsi/
 obj-$(CONFIG_SCSI_ESAS2R)	+= esas2r/
 obj-$(CONFIG_SCSI_PMCRAID)	+= pmcraid.o
 obj-$(CONFIG_SCSI_VIRTIO)	+= virtio_scsi.o
-obj-$(CONFIG_VMWARE_PVSCSI)	+= vmw_pvscsi.o
+obj-$(CONFIG_VMWARE_PVSCSI)	+= vmware/
 obj-$(CONFIG_XEN_SCSI_FRONTEND)	+= xen-scsifront.o
 obj-$(CONFIG_HYPERV_STORAGE)	+= hv_storvsc.o
 obj-$(CONFIG_SCSI_WD719X)	+= wd719x.o
diff --git a/drivers/scsi/vmware/Kconfig b/drivers/scsi/vmware/Kconfig
new file mode 100644
index 0000000..3c0c53b
--- /dev/null
+++ b/drivers/scsi/vmware/Kconfig
@@ -0,0 +1,7 @@
+config VMWARE_PVSCSI
+	tristate "VMware PVSCSI driver support"
+	depends on PCI && SCSI && X86
+	help
+	  This driver supports VMware's para virtualized SCSI HBA.
+	  To compile this driver as a module, choose M here: the
+	  module will be called vmw_pvscsi.
diff --git a/drivers/scsi/vmware/Makefile b/drivers/scsi/vmware/Makefile
new file mode 100644
index 0000000..ae8d278
--- /dev/null
+++ b/drivers/scsi/vmware/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_VMWARE_PVSCSI)    += vmw_pvscsi.o
diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmware/vmw_pvscsi.c
similarity index 99%
rename from drivers/scsi/vmw_pvscsi.c
rename to drivers/scsi/vmware/vmw_pvscsi.c
index 6164634..eb1229e 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmware/vmw_pvscsi.c
@@ -12,13 +12,6 @@
  * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
  * NON INFRINGEMENT.  See the GNU General Public License for more
  * details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
- *
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
- *
  */
 
 #include <linux/kernel.h>
diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmware/vmw_pvscsi.h
similarity index 98%
rename from drivers/scsi/vmw_pvscsi.h
rename to drivers/scsi/vmware/vmw_pvscsi.h
index 12712c9..5f675b9 100644
--- a/drivers/scsi/vmw_pvscsi.h
+++ b/drivers/scsi/vmware/vmw_pvscsi.h
@@ -12,13 +12,6 @@
  * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
  * NON INFRINGEMENT.  See the GNU General Public License for more
  * details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
- *
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
- *
  */
 
 #ifndef _VMW_PVSCSI_H_
-- 
2.8.0.rc4.16.g56331f8

[toc] | [prev] | [next] | [standalone]

#1425370 — Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

FromJim Gill <jgill@vmware.com>
Date2016-06-17 20:20 +0200
SubjectRe: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Message-ID<rL6x3-1wz-9@gated-at.bofh.it>
In reply to#1425366
I don’t yet know enough to comment on the relocation of vmw_pvscsi into a new vmware folder.
I was considering offering a new patch that removed the “maintained by” from the two source
files and updated MAINTAINERS, but I’m happy to defer to people with more experience. I’m
fine either way. 

On 6/17/16, 11:06 AM, "Joe Perches" <joe@perches.com> wrote:



>
>Perhaps a patch like this:
>
>From e727c6549e3be466ec3c79e919502cb0b9909b03 Mon Sep 17 00:00:00 2001
>Message-Id: <e727c6549e3be466ec3c79e919502cb0b9909b03.1466186573.git.joe@perches.com>
>From: Joe Perches <joe@perches.com>
>Date: Fri, 17 Jun 2016 10:56:49 -0700
>Subject: [PATCH] vmw_pvscsi: Move into separate directory, Jim Gill is MAINTAINER
>
>Separate directories for drivers are generally better.
>
>Miscellanea:
>
>o Update the MAINTAINER entry
>o Remove maintainer and FSF addresses from driver files
>---
> MAINTAINERS                            | 5 ++---
> drivers/scsi/Kconfig                   | 8 +-------
> drivers/scsi/Makefile                  | 2 +-
> drivers/scsi/vmware/Kconfig            | 7 +++++++
> drivers/scsi/vmware/Makefile           | 1 +
> drivers/scsi/{ => vmware}/vmw_pvscsi.c | 7 -------
> drivers/scsi/{ => vmware}/vmw_pvscsi.h | 7 -------
> 7 files changed, 12 insertions(+), 25 deletions(-)
> create mode 100644 drivers/scsi/vmware/Kconfig
> create mode 100644 drivers/scsi/vmware/Makefile
> rename drivers/scsi/{ => vmware}/vmw_pvscsi.c (99%)
> rename drivers/scsi/{ => vmware}/vmw_pvscsi.h (98%)
>
>diff --git a/MAINTAINERS b/MAINTAINERS
>index d174e34..2763582 100644
>--- a/MAINTAINERS
>+++ b/MAINTAINERS
>@@ -12421,12 +12421,11 @@ S:	Maintained
> F:	drivers/net/vmxnet3/
> 
> VMware PVSCSI driver
>-M:	Arvind Kumar <arvindkumar@vmware.com>
>+M:	Jim Gill <jgill@vmware.com>
> M:	VMware PV-Drivers <pv-drivers@vmware.com>
> L:	linux-scsi@vger.kernel.org
> S:	Maintained
>-F:	drivers/scsi/vmw_pvscsi.c
>-F:	drivers/scsi/vmw_pvscsi.h
>+F:	drivers/scsi/vmware/
> 
> VOLTAGE AND CURRENT REGULATOR FRAMEWORK
> M:	Liam Girdwood <lgirdwood@gmail.com>
>diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
>index 1918f54..339c230 100644
>--- a/drivers/scsi/Kconfig
>+++ b/drivers/scsi/Kconfig
>@@ -576,13 +576,7 @@ config SCSI_FLASHPOINT
> 	  substantial, so users of MultiMaster Host Adapters may not
> 	  wish to include it.
> 
>-config VMWARE_PVSCSI
>-	tristate "VMware PVSCSI driver support"
>-	depends on PCI && SCSI && X86
>-	help
>-	  This driver supports VMware's para virtualized SCSI HBA.
>-	  To compile this driver as a module, choose M here: the
>-	  module will be called vmw_pvscsi.
>+source "drivers/scsi/vmware/Kconfig"
> 
> config XEN_SCSI_FRONTEND
> 	tristate "XEN SCSI frontend driver"
>diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
>index 862ab4e..6cfefaa 100644
>--- a/drivers/scsi/Makefile
>+++ b/drivers/scsi/Makefile
>@@ -141,7 +141,7 @@ obj-$(CONFIG_BE2ISCSI)		+= libiscsi.o be2iscsi/
> obj-$(CONFIG_SCSI_ESAS2R)	+= esas2r/
> obj-$(CONFIG_SCSI_PMCRAID)	+= pmcraid.o
> obj-$(CONFIG_SCSI_VIRTIO)	+= virtio_scsi.o
>-obj-$(CONFIG_VMWARE_PVSCSI)	+= vmw_pvscsi.o
>+obj-$(CONFIG_VMWARE_PVSCSI)	+= vmware/
> obj-$(CONFIG_XEN_SCSI_FRONTEND)	+= xen-scsifront.o
> obj-$(CONFIG_HYPERV_STORAGE)	+= hv_storvsc.o
> obj-$(CONFIG_SCSI_WD719X)	+= wd719x.o
>diff --git a/drivers/scsi/vmware/Kconfig b/drivers/scsi/vmware/Kconfig
>new file mode 100644
>index 0000000..3c0c53b
>--- /dev/null
>+++ b/drivers/scsi/vmware/Kconfig
>@@ -0,0 +1,7 @@
>+config VMWARE_PVSCSI
>+	tristate "VMware PVSCSI driver support"
>+	depends on PCI && SCSI && X86
>+	help
>+	  This driver supports VMware's para virtualized SCSI HBA.
>+	  To compile this driver as a module, choose M here: the
>+	  module will be called vmw_pvscsi.
>diff --git a/drivers/scsi/vmware/Makefile b/drivers/scsi/vmware/Makefile
>new file mode 100644
>index 0000000..ae8d278
>--- /dev/null
>+++ b/drivers/scsi/vmware/Makefile
>@@ -0,0 +1 @@
>+obj-$(CONFIG_VMWARE_PVSCSI)    += vmw_pvscsi.o
>diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmware/vmw_pvscsi.c
>similarity index 99%
>rename from drivers/scsi/vmw_pvscsi.c
>rename to drivers/scsi/vmware/vmw_pvscsi.c
>index 6164634..eb1229e 100644
>--- a/drivers/scsi/vmw_pvscsi.c
>+++ b/drivers/scsi/vmware/vmw_pvscsi.c
>@@ -12,13 +12,6 @@
>  * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
>  * NON INFRINGEMENT.  See the GNU General Public License for more
>  * details.
>- *
>- * You should have received a copy of the GNU General Public License
>- * along with this program; if not, write to the Free Software
>- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
>- *
>- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
>- *
>  */
> 
> #include <linux/kernel.h>
>diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmware/vmw_pvscsi.h
>similarity index 98%
>rename from drivers/scsi/vmw_pvscsi.h
>rename to drivers/scsi/vmware/vmw_pvscsi.h
>index 12712c9..5f675b9 100644
>--- a/drivers/scsi/vmw_pvscsi.h
>+++ b/drivers/scsi/vmware/vmw_pvscsi.h
>@@ -12,13 +12,6 @@
>  * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
>  * NON INFRINGEMENT.  See the GNU General Public License for more
>  * details.
>- *
>- * You should have received a copy of the GNU General Public License
>- * along with this program; if not, write to the Free Software
>- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
>- *
>- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
>- *
>  */
> 
> #ifndef _VMW_PVSCSI_H_
>-- 
>2.8.0.rc4.16.g56331f8
>

[toc] | [prev] | [next] | [standalone]

#1427211

From"Martin K. Petersen" <martin.petersen@oracle.com>
Date2016-06-21 04:10 +0200
Message-ID<rMjiy-7VH-7@gated-at.bofh.it>
In reply to#1424585
>>>>> "Jim" == Jim Gill <jgill@vmware.com> writes:

Updated MAINTAINERS accordingly and applied to 4.8/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web