Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424794

Re: [Pv-drivers] [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Show all headers | View raw

Hi!

IMO we shouldn't have maintainer info mentioned in the source files,
since the information is redundant and moreover if we change maintainer
a patch touching multiple files would just look odd, and we'd leave a
lot of stale info in older kernels.

Having the linux git *master* MAINTAINERS file as the authoritative
information source for this makes most sense. If there are different
maintainers of different parts of a single module we should be able to
sort that out internally.

Thanks,
Thomas



On 06/17/2016 05:11 AM, Julian Calaby wrote:
> Hi Joe,
>
> On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <joe@perches.com> wrote:
>> On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
>>> Hi Joe,
>> rehi Julian.
> (I always put a salutation on my emails and always finish them with
> "Thanks," =) )
>
>>> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote:
>> []
>>>> get_maintainer.pl also has a rarely used "--file-emails" option to
>>>> scan for what appears to be email addresses in specific files.
>>>>
>>>> $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
>>>> Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file)
>>>> VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver)
>>>> "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM)
>>>> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
>>>> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
>>>> linux-kernel@vger.kernel.org (open list)
>>>>
>>>> note the "in file" after Arvind's name
>>> Didn't know this, however my point stands: the maintainer line in the
>>> file is redundant if we find maintainers through MAINTAINERS or the
>>> get_maintainer.pl script.
>> Yes, I'm not suggesting anything else.  Jim's name
>> should appear in the MAINTAINERS file somewhere.
>>
>> The question to me is whether or not Jim Gill is
>> taking over the maintainership of the entire
>> VMware PVSCSI driver or just a few files of it.
> As I see it, he's taking over maintainership of all of it: it's only
> files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.
>
> Thanks,
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Jim Gill <jgill@vmware.com> - 2016-06-17 03:20 +0200
  Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Arvind Kumar <arvindkumar@vmware.com> - 2016-06-17 03:40 +0200
  Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Julian Calaby <julian.calaby@gmail.com> - 2016-06-17 03:50 +0200
    Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Arvind Kumar <arvindkumar@vmware.com> - 2016-06-17 04:10 +0200
      Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Julian Calaby <julian.calaby@gmail.com> - 2016-06-17 04:20 +0200
        Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Joe Perches <joe@perches.com> - 2016-06-17 04:40 +0200
          Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Julian Calaby <julian.calaby@gmail.com> - 2016-06-17 04:50 +0200
            Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Joe Perches <joe@perches.com> - 2016-06-17 05:10 +0200
              Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Julian Calaby <julian.calaby@gmail.com> - 2016-06-17 05:20 +0200
                Re: [Pv-drivers] [PATCH] VMW_PVSCSI: Change to update maintainer  details (name, email) Thomas Hellstrom <thellstrom@vmware.com> - 2016-06-17 10:20 +0200
                Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Jim Gill <jgill@vmware.com> - 2016-06-17 19:50 +0200
                Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Joe Perches <joe@perches.com> - 2016-06-17 20:10 +0200
                Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,  email) Jim Gill <jgill@vmware.com> - 2016-06-17 20:20 +0200
  Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-06-21 04:10 +0200

csiph-web