Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1420993 > unrolled thread
| Started by | weiyj_lk@163.com |
|---|---|
| First post | 2016-06-13 17:30 +0200 |
| Last post | 2016-06-13 19:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH -next] rcutorture: Fix error return code in rcu_perf_init() weiyj_lk@163.com - 2016-06-13 17:30 +0200
Re: [PATCH -next] rcutorture: Fix error return code in rcu_perf_init() "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-13 19:00 +0200
| From | weiyj_lk@163.com |
|---|---|
| Date | 2016-06-13 17:30 +0200 |
| Subject | [PATCH -next] rcutorture: Fix error return code in rcu_perf_init() |
| Message-ID | <rJBYm-86X-25@gated-at.bofh.it> |
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code -ENOMEM from kcalloc() error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
kernel/rcu/rcuperf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 7b2dbdf..d38ab08 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -638,8 +638,10 @@ rcu_perf_init(void)
writer_durations[i] =
kcalloc(MAX_MEAS, sizeof(*writer_durations[i]),
GFP_KERNEL);
- if (!writer_durations[i])
+ if (!writer_durations[i]) {
+ firsterr = -ENOMEM;
goto unwind;
+ }
firsterr = torture_create_kthread(rcu_perf_writer, (void *)i,
writer_tasks[i]);
if (firsterr)
[toc] | [next] | [standalone]
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-06-13 19:00 +0200 |
| Subject | Re: [PATCH -next] rcutorture: Fix error return code in rcu_perf_init() |
| Message-ID | <rJDnr-sX-29@gated-at.bofh.it> |
| In reply to | #1420993 |
On Mon, Jun 13, 2016 at 03:20:39PM +0000, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code -ENOMEM from kcalloc() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Good eyes! Queued for review and testing.
Thanx, Paul
> ---
> kernel/rcu/rcuperf.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 7b2dbdf..d38ab08 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -638,8 +638,10 @@ rcu_perf_init(void)
> writer_durations[i] =
> kcalloc(MAX_MEAS, sizeof(*writer_durations[i]),
> GFP_KERNEL);
> - if (!writer_durations[i])
> + if (!writer_durations[i]) {
> + firsterr = -ENOMEM;
> goto unwind;
> + }
> firsterr = torture_create_kthread(rcu_perf_writer, (void *)i,
> writer_tasks[i]);
> if (firsterr)
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web