Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1421056

Re: [PATCH -next] rcutorture: Fix error return code in rcu_perf_init()

Show all headers | View raw

On Mon, Jun 13, 2016 at 03:20:39PM +0000, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fix to return a negative error code -ENOMEM from kcalloc() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Good eyes!  Queued for review and testing.

							Thanx, Paul

> ---
>  kernel/rcu/rcuperf.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 7b2dbdf..d38ab08 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -638,8 +638,10 @@ rcu_perf_init(void)
>  		writer_durations[i] =
>  			kcalloc(MAX_MEAS, sizeof(*writer_durations[i]),
>  				GFP_KERNEL);
> -		if (!writer_durations[i])
> +		if (!writer_durations[i]) {
> +			firsterr = -ENOMEM;
>  			goto unwind;
> +		}
>  		firsterr = torture_create_kthread(rcu_perf_writer, (void *)i,
>  						  writer_tasks[i]);
>  		if (firsterr)
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] rcutorture: Fix error return code in rcu_perf_init() weiyj_lk@163.com - 2016-06-13 17:30 +0200
  Re: [PATCH -next] rcutorture: Fix error return code in  rcu_perf_init() "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-13 19:00 +0200

csiph-web