Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411776 > unrolled thread

[PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

Started byluoyi.ly@gmail.com
First post2016-06-02 04:40 +0200
Last post2016-06-10 11:40 +0200
Articles 7 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly@gmail.com - 2016-06-02 04:40 +0200
    Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Julian Calaby <julian.calaby@gmail.com> - 2016-06-02 05:00 +0200
      Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-02 10:20 +0200
        Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Bernhard Nortmann <bernhard.nortmann@web.de> - 2016-06-02 11:20 +0200
          Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly@gmail.com - 2016-06-03 08:10 +0200
            Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-10 11:40 +0200
          Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-10 11:40 +0200

#1411776 — [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

Fromluoyi.ly@gmail.com
Date2016-06-02 04:40 +0200
Subject[PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Message-ID<rFqI9-50-7@gated-at.bofh.it>
From: Luo Yi <luoyi.ly@gmail.com>

Add support for the Bananapi M1 Plus A20 development board from
sinovoip.com.cn . This board is nearly a clone of the Lemaker's
Bananapro, but differ with the wlan chipset connection and i2s pinout.
And I also enable the integrated audio codec on default.
---
 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 72 ++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts

diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
new file mode 100644
index 0000000..6fd55d7
--- /dev/null
+++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
@@ -0,0 +1,72 @@
+/*
+ * Copyright 2016 Luo Yi <luoyi.ly@gmail.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "sun7i-a20-bananapro.dts"
+
+/ {
+	model = "Banana Pi BPI-M1-Plus";
+	compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
+};
+
+
+&codec {
+	status = "okay";
+};
+
+&mmc3 {
+	enable-sdio-wakeup;
+
+	brcmf: bcrmf@1 {
+		reg = <1>;
+		compatible = "brcm,bcm4329-fmac";
+		interrupt-parent = <&pio>;
+		interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>; 
+		interrupt-names = "host-wake";
+	};
+
+};
+
+&mmc3_pins_a {
+    /* AP6210 requires pull-up */
+	allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
+};
+
-- 
2.8.3

[toc] | [next] | [standalone]

#1411791 — Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

FromJulian Calaby <julian.calaby@gmail.com>
Date2016-06-02 05:00 +0200
SubjectRe: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Message-ID<rFr1w-bC-13@gated-at.bofh.it>
In reply to#1411776
Hi Luo yi,

On Thu, Jun 2, 2016 at 12:36 PM,  <luoyi.ly@gmail.com> wrote:
> From: Luo Yi <luoyi.ly@gmail.com>
>
> Add support for the Bananapi M1 Plus A20 development board from
> sinovoip.com.cn . This board is nearly a clone of the Lemaker's
> Bananapro, but differ with the wlan chipset connection and i2s pinout.
> And I also enable the integrated audio codec on default.

No signed-off-by.

> ---
>  arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 72 ++++++++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> new file mode 100644
> index 0000000..6fd55d7
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> @@ -0,0 +1,72 @@
> +/*
> + * Copyright 2016 Luo Yi <luoyi.ly@gmail.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include "sun7i-a20-bananapro.dts"
> +
> +/ {
> +       model = "Banana Pi BPI-M1-Plus";
> +       compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
> +};
> +
> +

Extra line.

> +&codec {
> +       status = "okay";
> +};

Does anyone know if this should be enabled on the bananapro too?

> +
> +&mmc3 {
> +       enable-sdio-wakeup;
> +
> +       brcmf: bcrmf@1 {
> +               reg = <1>;
> +               compatible = "brcm,bcm4329-fmac";
> +               interrupt-parent = <&pio>;
> +               interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>;
> +               interrupt-names = "host-wake";
> +       };
> +

Extra line.

> +};
> +
> +&mmc3_pins_a {
> +    /* AP6210 requires pull-up */

Should this be indented the same as the following line?

> +       allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
> +};
> +

Extra line.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

[toc] | [prev] | [next] | [standalone]

#1411984 — Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-06-02 10:20 +0200
SubjectRe: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Message-ID<rFw1b-3rP-5@gated-at.bofh.it>
In reply to#1411791

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jun 02, 2016 at 12:55:23PM +1000, Julian Calaby wrote:
> Hi Luo yi,
> 
> On Thu, Jun 2, 2016 at 12:36 PM,  <luoyi.ly@gmail.com> wrote:
> > From: Luo Yi <luoyi.ly@gmail.com>
> >
> > Add support for the Bananapi M1 Plus A20 development board from
> > sinovoip.com.cn . This board is nearly a clone of the Lemaker's
> > Bananapro, but differ with the wlan chipset connection and i2s pinout.
> > And I also enable the integrated audio codec on default.
> 
> No signed-off-by.
> 
> > ---
> >  arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 72 ++++++++++++++++++++++++
> >  1 file changed, 72 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> >
> > diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> > new file mode 100644
> > index 0000000..6fd55d7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> > @@ -0,0 +1,72 @@
> > +/*
> > + * Copyright 2016 Luo Yi <luoyi.ly@gmail.com>
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPL or the X11 license, at your option. Note that this dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + *  a) This file is free software; you can redistribute it and/or
> > + *     modify it under the terms of the GNU General Public License as
> > + *     published by the Free Software Foundation; either version 2 of the
> > + *     License, or (at your option) any later version.
> > + *
> > + *     This file is distributed in the hope that it will be useful,
> > + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + *     GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + *  b) Permission is hereby granted, free of charge, to any person
> > + *     obtaining a copy of this software and associated documentation
> > + *     files (the "Software"), to deal in the Software without
> > + *     restriction, including without limitation the rights to use,
> > + *     copy, modify, merge, publish, distribute, sublicense, and/or
> > + *     sell copies of the Software, and to permit persons to whom the
> > + *     Software is furnished to do so, subject to the following
> > + *     conditions:
> > + *
> > + *     The above copyright notice and this permission notice shall be
> > + *     included in all copies or substantial portions of the Software.
> > + *
> > + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > + *     OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +
> > +#include "sun7i-a20-bananapro.dts"
> > +
> > +/ {
> > +       model = "Banana Pi BPI-M1-Plus";
> > +       compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
> > +};
> > +
> > +
> 
> Extra line.
> 
> > +&codec {
> > +       status = "okay";
> > +};
> 
> Does anyone know if this should be enabled on the bananapro too?

Yes, everything that is shared with the banana-pro (which, judging
from Bernhard, is pretty much everything but a GPIO) should be merged
in the banapro DT.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1412023 — Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

FromBernhard Nortmann <bernhard.nortmann@web.de>
Date2016-06-02 11:20 +0200
SubjectRe: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Message-ID<rFwXg-450-19@gated-at.bofh.it>
In reply to#1411984
Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> [...]
> Yes, everything that is shared with the banana-pro (which, judging
> from Bernhard, is pretty much everything but a GPIO) should be merged
> in the banapro DT.
>
> Maxime
>

Don't take my word for granted, as I do not own this hardware or know it
particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
very similar, but if in doubt the information form the wiki should be 
verified.

@luoyi:

You seem to be using an editor that uses 4 spaces for displaying a <TAB>.
It looks like that makes you prone to whitespace formatting issues, which
have shown up in both versions of the .dts you submitted so far.

Please double-check that you're using TABs for indentation and they weren't
mixed up with SPACEs accidentally. (Most editors will also offer a setting
that allows you to display "non-printable" chars, where you might be able to
distinguish whitespace better.)

Regards, B. Nortmann

[toc] | [prev] | [next] | [standalone]

#1412828 — Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

Fromluoyi.ly@gmail.com
Date2016-06-03 08:10 +0200
SubjectRe: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Message-ID<rFQsW-7XL-9@gated-at.bofh.it>
In reply to#1412023
From: Luo Yi <luoyi.ly@gmail.com>

Remove the extra empty line and add signed off. 

Signed-off-by: Luo Yi <luoyi.ly@gmail.com>
---
 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
index 6fd55d7..f9063ba 100644
--- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
@@ -47,7 +47,6 @@
 	compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
 };
 
-
 &codec {
 	status = "okay";
 };
@@ -62,11 +61,8 @@
 		interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>; 
 		interrupt-names = "host-wake";
 	};
-
 };
 
 &mmc3_pins_a {
-    /* AP6210 requires pull-up */
 	allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
 };
-
-- 
2.8.3

[toc] | [prev] | [next] | [standalone]

#1419161 — Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-06-10 11:40 +0200
SubjectRe: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Message-ID<rIr50-2Pg-33@gated-at.bofh.it>
In reply to#1412828

[Multipart message — attachments visible in raw view] — view raw

On Fri, Jun 03, 2016 at 02:13:36PM +0800, luoyi.ly@gmail.com wrote:
> From: Luo Yi <luoyi.ly@gmail.com>
> 
> Remove the extra empty line and add signed off. 
> 
> Signed-off-by: Luo Yi <luoyi.ly@gmail.com>

Please send a new patch.

> ---
>  arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> index 6fd55d7..f9063ba 100644
> --- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> @@ -47,7 +47,6 @@
>  	compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
>  };
>  
> -
>  &codec {
>  	status = "okay";
>  };
> @@ -62,11 +61,8 @@
>  		interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>; 
>  		interrupt-names = "host-wake";
>  	};
> -
>  };
>  
>  &mmc3_pins_a {
> -    /* AP6210 requires pull-up */

And that comment was fine, why did you remove it?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1419158 — Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-06-10 11:40 +0200
SubjectRe: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Message-ID<rIr50-2Pg-15@gated-at.bofh.it>
In reply to#1412023

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> >[...]
> >Yes, everything that is shared with the banana-pro (which, judging
> >from Bernhard, is pretty much everything but a GPIO) should be merged
> >in the banapro DT.
> >
> >Maxime
> >
> 
> Don't take my word for granted, as I do not own this hardware or know it
> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
> very similar, but if in doubt the information form the wiki should be
> verified.

Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
more than I do.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web