Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1419161

Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Date 2016-06-10 11:40 +0200
Message-ID <rIr50-2Pg-33@gated-at.bofh.it> (permalink)
References <rFwXg-450-19@gated-at.bofh.it> <rFQsW-7XL-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, Jun 03, 2016 at 02:13:36PM +0800, luoyi.ly@gmail.com wrote:
> From: Luo Yi <luoyi.ly@gmail.com>
> 
> Remove the extra empty line and add signed off. 
> 
> Signed-off-by: Luo Yi <luoyi.ly@gmail.com>

Please send a new patch.

> ---
>  arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> index 6fd55d7..f9063ba 100644
> --- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> @@ -47,7 +47,6 @@
>  	compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
>  };
>  
> -
>  &codec {
>  	status = "okay";
>  };
> @@ -62,11 +61,8 @@
>  		interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>; 
>  		interrupt-names = "host-wake";
>  	};
> -
>  };
>  
>  &mmc3_pins_a {
> -    /* AP6210 requires pull-up */

And that comment was fine, why did you remove it?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly@gmail.com - 2016-06-02 04:40 +0200
  Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Julian Calaby <julian.calaby@gmail.com> - 2016-06-02 05:00 +0200
    Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-02 10:20 +0200
      Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Bernhard Nortmann <bernhard.nortmann@web.de> - 2016-06-02 11:20 +0200
        Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly@gmail.com - 2016-06-03 08:10 +0200
          Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-10 11:40 +0200
        Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for  Bananapi M1 Plus board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-10 11:40 +0200

csiph-web