Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1419758 > unrolled thread

[PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-11 00:10 +0200
    Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting  ATMEL_PIT Thomas Gleixner <tglx@linutronix.de> - 2016-06-11 11:50 +0200
      Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-11 13:00 +0200
        Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting  ATMEL_PIT Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-13 21:10 +0200
          Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting  ATMEL_PIT Thomas Gleixner <tglx@linutronix.de> - 2016-06-13 21:20 +0200
            Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting  ATMEL_PIT Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-16 16:50 +0200

#1419758 — [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT

With the new TCB clocksource driver, atmel platforms are now able to boot
without the PIT driver. Allow unselecting it.

Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/clocksource/Kconfig | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 1860f6f9b380..c651661bf43c 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -251,7 +251,14 @@ config ARMV7M_SYSTICK
 
 config ATMEL_PIT
 	select CLKSRC_OF if OF
-	def_bool SOC_AT91SAM9 || SOC_SAMA5
+	bool "Atmel Periodic Interval Timer (PIT)"
+	depends on SOC_AT91SAM9 || SOC_SAMA5
+	default SOC_AT91SAM9 || SOC_SAMA5
+	help
+	  Select this to get a clocksource based on the Atmel Periodic Interval
+	  Timer. It has a relatively low resolution and the TC Block clocksource
+	  should be preferred.
+	  It also provides a clock event device.
 
 config ATMEL_ST
 	bool
-- 
2.8.1

[toc] | [next] | [standalone]

#1419953 — Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT

On Sat, 11 Jun 2016, Alexandre Belloni wrote:

> With the new TCB clocksource driver, atmel platforms are now able to boot
> without the PIT driver. Allow unselecting it.

Yay! Thanks for doing this!

     tglx

 

[toc] | [prev] | [next] | [standalone]

#1419964

On 11/06/2016 at 11:43:54 +0200, Thomas Gleixner wrote :
> On Sat, 11 Jun 2016, Alexandre Belloni wrote:
> 
> > With the new TCB clocksource driver, atmel platforms are now able to boot
> > without the PIT driver. Allow unselecting it.
> 
> Yay! Thanks for doing this!
> 

Sure! Can you still check the request_irq/free_irq in
timer-atmel-tcbclksrc? I'm not sure whether this can work reliably or
only because we are before SYSTEM_STATE=RUNNING.
In the latter case, I have another way of doing that.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1421180 — Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT

On Sat, 11 Jun 2016 12:53:51 +0200
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> On 11/06/2016 at 11:43:54 +0200, Thomas Gleixner wrote :
> > On Sat, 11 Jun 2016, Alexandre Belloni wrote:
> >   
> > > With the new TCB clocksource driver, atmel platforms are now able to boot
> > > without the PIT driver. Allow unselecting it.  
> > 
> > Yay! Thanks for doing this!
> >   
> 
> Sure! Can you still check the request_irq/free_irq in
> timer-atmel-tcbclksrc? I'm not sure whether this can work reliably or
> only because we are before SYSTEM_STATE=RUNNING.
> In the latter case, I have another way of doing that.
> 

Sorry to put it back on the table, but shouldn't we consider adding
these irq_disable/enable_action() helpers?

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1421224 — Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT

On Mon, 13 Jun 2016, Boris Brezillon wrote:
> On Sat, 11 Jun 2016 12:53:51 +0200
> Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> 
> > On 11/06/2016 at 11:43:54 +0200, Thomas Gleixner wrote :
> > > On Sat, 11 Jun 2016, Alexandre Belloni wrote:
> > >   
> > > > With the new TCB clocksource driver, atmel platforms are now able to boot
> > > > without the PIT driver. Allow unselecting it.  
> > > 
> > > Yay! Thanks for doing this!
> > >   
> > 
> > Sure! Can you still check the request_irq/free_irq in
> > timer-atmel-tcbclksrc? I'm not sure whether this can work reliably or
> > only because we are before SYSTEM_STATE=RUNNING.
> > In the latter case, I have another way of doing that.
> > 
> 
> Sorry to put it back on the table, but shouldn't we consider adding
> these irq_disable/enable_action() helpers?

I fear that's the only reliable way to do it.

[toc] | [prev] | [next] | [standalone]

#1424139 — Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT

Hi Thomas,

On Mon, 13 Jun 2016 21:14:47 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 13 Jun 2016, Boris Brezillon wrote:
> > On Sat, 11 Jun 2016 12:53:51 +0200
> > Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> >   
> > > On 11/06/2016 at 11:43:54 +0200, Thomas Gleixner wrote :  
> > > > On Sat, 11 Jun 2016, Alexandre Belloni wrote:
> > > >     
> > > > > With the new TCB clocksource driver, atmel platforms are now able to boot
> > > > > without the PIT driver. Allow unselecting it.    
> > > > 
> > > > Yay! Thanks for doing this!
> > > >     
> > > 
> > > Sure! Can you still check the request_irq/free_irq in
> > > timer-atmel-tcbclksrc? I'm not sure whether this can work reliably or
> > > only because we are before SYSTEM_STATE=RUNNING.
> > > In the latter case, I have another way of doing that.
> > >   
> > 
> > Sorry to put it back on the table, but shouldn't we consider adding
> > these irq_disable/enable_action() helpers?  
> 
> I fear that's the only reliable way to do it.

Alexandre told me you had a better implementation (or idea, I don't
remember) than what was proposed here [1].
Do you plan to submit something, or should we work on it?

Regards,

Boris

[1]https://lkml.org/lkml/2015/8/3/330

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web