Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT
Date	2016-06-16 16:50 +0200
Message-ID	<rKGMh-18f-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <rICMO-2IE-13@gated-at.bofh.it> <rINId-1ny-3@gated-at.bofh.it> <rIONX-21C-19@gated-at.bofh.it> <rJFpg-22H-9@gated-at.bofh.it> <rJFyW-26n-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Thomas,

On Mon, 13 Jun 2016 21:14:47 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 13 Jun 2016, Boris Brezillon wrote:
> > On Sat, 11 Jun 2016 12:53:51 +0200
> > Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> >   
> > > On 11/06/2016 at 11:43:54 +0200, Thomas Gleixner wrote :  
> > > > On Sat, 11 Jun 2016, Alexandre Belloni wrote:
> > > >     
> > > > > With the new TCB clocksource driver, atmel platforms are now able to boot
> > > > > without the PIT driver. Allow unselecting it.    
> > > > 
> > > > Yay! Thanks for doing this!
> > > >     
> > > 
> > > Sure! Can you still check the request_irq/free_irq in
> > > timer-atmel-tcbclksrc? I'm not sure whether this can work reliably or
> > > only because we are before SYSTEM_STATE=RUNNING.
> > > In the latter case, I have another way of doing that.
> > >   
> > 
> > Sorry to put it back on the table, but shouldn't we consider adding
> > these irq_disable/enable_action() helpers?  
> 
> I fear that's the only reliable way to do it.

Alexandre told me you had a better implementation (or idea, I don't
remember) than what was proposed here [1].
Do you plan to submit something, or should we work on it?

Regards,

Boris

[1]https://lkml.org/lkml/2015/8/3/330

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting  ATMEL_PIT Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-13 21:10 +0200
  Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting  ATMEL_PIT Thomas Gleixner <tglx@linutronix.de> - 2016-06-13 21:20 +0200
    Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting  ATMEL_PIT Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-16 16:50 +0200

csiph-web