Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1418340 > unrolled thread
| Started by | Kieran Bingham <kieran@ksquared.org.uk> |
|---|---|
| First post | 2016-06-09 15:50 +0200 |
| Last post | 2016-06-10 23:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham <kieran@ksquared.org.uk> - 2016-06-09 15:50 +0200
Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Rob Herring <robh@kernel.org> - 2016-06-10 19:40 +0200
Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-10 21:20 +0200
Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Rob Herring <robh@kernel.org> - 2016-06-10 23:40 +0200
| From | Kieran Bingham <kieran@ksquared.org.uk> |
|---|---|
| Date | 2016-06-09 15:50 +0200 |
| Subject | [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage |
| Message-ID | <rI8vo-72W-25@gated-at.bofh.it> |
The power domain must be specified to bring the device out of module standby. Document this in the example provided, so that new additions are not missed. Signed-off-by: Kieran Bingham <kieran@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt index 271dcfdb5a76..6a55f5215221 100644 --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt @@ -31,4 +31,5 @@ Device node example compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; reg = <0 0xfea2f000 0 0x200>; clocks = <&cpg CPG_MOD 602>; + power-domains = <&sysc R8A7795_PD_A3VP>; }; -- 2.7.4
[toc] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-06-10 19:40 +0200 |
| Subject | Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage |
| Message-ID | <rIyzw-7xq-31@gated-at.bofh.it> |
| In reply to | #1418340 |
On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote: > The power domain must be specified to bring the device out of module > standby. Document this in the example provided, so that new additions > are not missed. > > Signed-off-by: Kieran Bingham <kieran@bingham.xyz> > --- > Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt > index 271dcfdb5a76..6a55f5215221 100644 > --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt > @@ -31,4 +31,5 @@ Device node example > compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; > reg = <0 0xfea2f000 0 0x200>; > clocks = <&cpg CPG_MOD 602>; > + power-domains = <&sysc R8A7795_PD_A3VP>; This needs to be documented above too, not just the example. > }; > -- > 2.7.4 >
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2016-06-10 21:20 +0200 |
| Message-ID | <rIA8h-qo-3@gated-at.bofh.it> |
| In reply to | #1419617 |
Hi Rob,
On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote:
> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
>> The power domain must be specified to bring the device out of module
>> standby. Document this in the example provided, so that new additions
>> are not missed.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>> Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> index 271dcfdb5a76..6a55f5215221 100644
>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> @@ -31,4 +31,5 @@ Device node example
>> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>> reg = <0 0xfea2f000 0 0x200>;
>> clocks = <&cpg CPG_MOD 602>;
>> + power-domains = <&sysc R8A7795_PD_A3VP>;
>
> This needs to be documented above too, not just the example.
Why? Power domains are an optional feature, whose presence depends
on the platform, not on the device.
Hence "power-domains" properties may appear in any device node.
Having to document them in every single binding document is overkill.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-06-10 23:40 +0200 |
| Message-ID | <rICjM-28R-21@gated-at.bofh.it> |
| In reply to | #1419672 |
On Fri, Jun 10, 2016 at 2:11 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Rob, > > On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote: >> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote: >>> The power domain must be specified to bring the device out of module >>> standby. Document this in the example provided, so that new additions >>> are not missed. >>> >>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz> >>> --- >>> Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt >>> index 271dcfdb5a76..6a55f5215221 100644 >>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt >>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt >>> @@ -31,4 +31,5 @@ Device node example >>> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; >>> reg = <0 0xfea2f000 0 0x200>; >>> clocks = <&cpg CPG_MOD 602>; >>> + power-domains = <&sysc R8A7795_PD_A3VP>; >> >> This needs to be documented above too, not just the example. > > Why? Power domains are an optional feature, whose presence depends > on the platform, not on the device. Examples are not documentation. The binding should stand on its own without the example. How did I know this is optional unless you document it as optional? How many power domains does the device have? > Hence "power-domains" properties may appear in any device node. > Having to document them in every single binding document is overkill. We do it for everything else pretty much. There's some exceptions like "status". I agree that we get a bunch of redundancy with random text describing the properties. I'm all for a structured syntax that can distill the device bindings down to the pertainent information. If only someone proposed using yaml or something... Rob
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web