Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1419672
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage |
| Date | 2016-06-10 21:20 +0200 |
| Message-ID | <rIA8h-qo-3@gated-at.bofh.it> (permalink) |
| References | <rI8vn-72W-3@gated-at.bofh.it> <rI8vo-72W-25@gated-at.bofh.it> <rIyzw-7xq-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Rob,
On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote:
> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
>> The power domain must be specified to bring the device out of module
>> standby. Document this in the example provided, so that new additions
>> are not missed.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>> Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> index 271dcfdb5a76..6a55f5215221 100644
>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> @@ -31,4 +31,5 @@ Device node example
>> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>> reg = <0 0xfea2f000 0 0x200>;
>> clocks = <&cpg CPG_MOD 602>;
>> + power-domains = <&sysc R8A7795_PD_A3VP>;
>
> This needs to be documented above too, not just the example.
Why? Power domains are an optional feature, whose presence depends
on the platform, not on the device.
Hence "power-domains" properties may appear in any device node.
Having to document them in every single binding document is overkill.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham <kieran@ksquared.org.uk> - 2016-06-09 15:50 +0200
Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Rob Herring <robh@kernel.org> - 2016-06-10 19:40 +0200
Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-10 21:20 +0200
Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Rob Herring <robh@kernel.org> - 2016-06-10 23:40 +0200
Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-12 10:50 +0200
csiph-web