Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415397 > unrolled thread

[PATCH 02/10] mm: swap: unexport __pagevec_lru_add()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 02/10] mm: swap: unexport __pagevec_lru_add() Johannes Weiner <hannes@cmpxchg.org> - 2016-06-06 22:00 +0200
    Re: [PATCH 02/10] mm: swap: unexport __pagevec_lru_add() Rik van Riel <riel@redhat.com> - 2016-06-06 23:40 +0200
    Re: [PATCH 02/10] mm: swap: unexport __pagevec_lru_add() Michal Hocko <mhocko@kernel.org> - 2016-06-07 11:10 +0200
    Re: [PATCH 02/10] mm: swap: unexport __pagevec_lru_add() Minchan Kim <minchan@kernel.org> - 2016-06-08 09:20 +0200

#1415397 — [PATCH 02/10] mm: swap: unexport __pagevec_lru_add()

There is currently no modular user of this function. We used to have
filesystems that open-coded the page cache instantiation, but luckily
they're all streamlined, and we don't want this to come back.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
 mm/swap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/swap.c b/mm/swap.c
index 95916142fc46..d810c3d95c97 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -860,7 +860,6 @@ void __pagevec_lru_add(struct pagevec *pvec)
 {
 	pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, NULL);
 }
-EXPORT_SYMBOL(__pagevec_lru_add);
 
 /**
  * pagevec_lookup_entries - gang pagecache lookup
-- 
2.8.3

[toc] | [next] | [standalone]

#1415497

[Multipart message — attachments visible in raw view] — view raw

On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote:
> There is currently no modular user of this function. We used to have
> filesystems that open-coded the page cache instantiation, but luckily
> they're all streamlined, and we don't want this to come back.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> 
Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All Rights Reversed.

[toc] | [prev] | [next] | [standalone]

#1415897

On Mon 06-06-16 15:48:28, Johannes Weiner wrote:
> There is currently no modular user of this function. We used to have
> filesystems that open-coded the page cache instantiation, but luckily
> they're all streamlined, and we don't want this to come back.

allmodconfig agrees with that

> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  mm/swap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/swap.c b/mm/swap.c
> index 95916142fc46..d810c3d95c97 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -860,7 +860,6 @@ void __pagevec_lru_add(struct pagevec *pvec)
>  {
>  	pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, NULL);
>  }
> -EXPORT_SYMBOL(__pagevec_lru_add);
>  
>  /**
>   * pagevec_lookup_entries - gang pagecache lookup
> -- 
> 2.8.3

-- 
Michal Hocko
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1416949

On Mon, Jun 06, 2016 at 03:48:28PM -0400, Johannes Weiner wrote:
> There is currently no modular user of this function. We used to have
> filesystems that open-coded the page cache instantiation, but luckily
> they're all streamlined, and we don't want this to come back.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Minchan Kim <minchan@kernel.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web