Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415897

Re: [PATCH 02/10] mm: swap: unexport __pagevec_lru_add()

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 02/10] mm: swap: unexport __pagevec_lru_add()
Date 2016-06-07 11:10 +0200
Message-ID <rHlbk-Mt-31@gated-at.bofh.it> (permalink)
References <rH8QO-Oc-9@gated-at.bofh.it> <rH8QO-Oc-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon 06-06-16 15:48:28, Johannes Weiner wrote:
> There is currently no modular user of this function. We used to have
> filesystems that open-coded the page cache instantiation, but luckily
> they're all streamlined, and we don't want this to come back.

allmodconfig agrees with that

> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  mm/swap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/swap.c b/mm/swap.c
> index 95916142fc46..d810c3d95c97 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -860,7 +860,6 @@ void __pagevec_lru_add(struct pagevec *pvec)
>  {
>  	pagevec_lru_move_fn(pvec, __pagevec_lru_add_fn, NULL);
>  }
> -EXPORT_SYMBOL(__pagevec_lru_add);
>  
>  /**
>   * pagevec_lookup_entries - gang pagecache lookup
> -- 
> 2.8.3

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 02/10] mm: swap: unexport __pagevec_lru_add() Johannes Weiner <hannes@cmpxchg.org> - 2016-06-06 22:00 +0200
  Re: [PATCH 02/10] mm: swap: unexport __pagevec_lru_add() Rik van Riel <riel@redhat.com> - 2016-06-06 23:40 +0200
  Re: [PATCH 02/10] mm: swap: unexport __pagevec_lru_add() Michal Hocko <mhocko@kernel.org> - 2016-06-07 11:10 +0200
  Re: [PATCH 02/10] mm: swap: unexport __pagevec_lru_add() Minchan Kim <minchan@kernel.org> - 2016-06-08 09:20 +0200

csiph-web