Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416860 > unrolled thread
| Started by | Wenyou Yang <wenyou.yang@atmel.com> |
|---|---|
| First post | 2016-06-08 06:30 +0200 |
| Last post | 2016-06-08 12:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v3 0/2] ARM: ohci-at91: Add support to forcibly suspend ports while sleep Wenyou Yang <wenyou.yang@atmel.com> - 2016-06-08 06:30 +0200
[PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node Wenyou Yang <wenyou.yang@atmel.com> - 2016-06-08 06:30 +0200
Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-08 12:10 +0200
Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-08 12:40 +0200
| From | Wenyou Yang <wenyou.yang@atmel.com> |
|---|---|
| Date | 2016-06-08 06:30 +0200 |
| Subject | [PATCH v3 0/2] ARM: ohci-at91: Add support to forcibly suspend ports while sleep |
| Message-ID | <rHDhT-3FX-3@gated-at.bofh.it> |
To save the power consumption, add a new compatible to support forcibly suspend the USB PORTA/B/C via OHCI Interrupt Configuration SFR Register. Changes in v3: - Change the compatible description for more precise. Changes in v2: - Add compatible to support forcibly suspend the ports. - Add soc/at91/at91_sfr.h to accommodate the defines. - Add error checking for .sfr_regmap. - Remove unnecessary regmap_read() statement. - Use the new compatible for ohci-node. Wenyou Yang (2): usb: ohci-at91: Forcibly suspend ports while USB suspend ARM: at91/dt: sama5d2: Use new compatible for ohci node .../devicetree/bindings/usb/atmel-usb.txt | 6 +- arch/arm/boot/dts/sama5d2.dtsi | 2 +- drivers/usb/host/ohci-at91.c | 80 +++++++++++++++++++++- include/soc/at91/at91_sfr.h | 29 ++++++++ 4 files changed, 113 insertions(+), 4 deletions(-) create mode 100644 include/soc/at91/at91_sfr.h -- 2.7.4
[toc] | [next] | [standalone]
| From | Wenyou Yang <wenyou.yang@atmel.com> |
|---|---|
| Date | 2016-06-08 06:30 +0200 |
| Subject | [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node |
| Message-ID | <rHDhY-3FX-5@gated-at.bofh.it> |
| In reply to | #1416860 |
Use compatible "atmel,sama5d2-ohci" to be capable of suspending
ports while sleep to save the power consumption.
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
Changes in v3: None
Changes in v2:
- Use the new compatible for ohci-node.
arch/arm/boot/dts/sama5d2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index 78996bd..03d6724 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -232,7 +232,7 @@
};
usb1: ohci@00400000 {
- compatible = "atmel,at91rm9200-ohci", "usb-ohci";
+ compatible = "atmel,sama5d2-ohci", "usb-ohci";
reg = <0x00400000 0x100000>;
interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>;
clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| Date | 2016-06-08 12:10 +0200 |
| Subject | Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node |
| Message-ID | <rHIAV-7fu-1@gated-at.bofh.it> |
| In reply to | #1416861 |
Le 08/06/2016 06:15, Wenyou Yang a écrit :
> Use compatible "atmel,sama5d2-ohci" to be capable of suspending
> ports while sleep to save the power consumption.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Use the new compatible for ohci-node.
>
> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 78996bd..03d6724 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -232,7 +232,7 @@
> };
>
> usb1: ohci@00400000 {
> - compatible = "atmel,at91rm9200-ohci", "usb-ohci";
> + compatible = "atmel,sama5d2-ohci", "usb-ohci";
We must change this to:
+ compatible = "atmel,sama5d2-ohci", "atmel,at91rm9200-ohci", "usb-ohci";
To make it independent from the one that may reach Mainline through the USB git tree.
> reg = <0x00400000 0x100000>;
> interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>;
> clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
>
Bye,
--
Nicolas Ferre
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-06-08 12:40 +0200 |
| Subject | Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node |
| Message-ID | <rHJ3X-7pn-3@gated-at.bofh.it> |
| In reply to | #1417233 |
On 08/06/2016 at 12:06:11 +0200, Nicolas Ferre wrote :
> Le 08/06/2016 06:15, Wenyou Yang a écrit :
> > Use compatible "atmel,sama5d2-ohci" to be capable of suspending
> > ports while sleep to save the power consumption.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> > Changes in v3: None
> > Changes in v2:
> > - Use the new compatible for ohci-node.
> >
> > arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> > index 78996bd..03d6724 100644
> > --- a/arch/arm/boot/dts/sama5d2.dtsi
> > +++ b/arch/arm/boot/dts/sama5d2.dtsi
> > @@ -232,7 +232,7 @@
> > };
> >
> > usb1: ohci@00400000 {
> > - compatible = "atmel,at91rm9200-ohci", "usb-ohci";
> > + compatible = "atmel,sama5d2-ohci", "usb-ohci";
>
> We must change this to:
> + compatible = "atmel,sama5d2-ohci", "atmel,at91rm9200-ohci", "usb-ohci";
>
> To make it independent from the one that may reach Mainline through the USB git tree.
>
Well, like discussed, I'd say that a new compatible is not needed as we
already know on which chip we are running depending on the SFR that we
can lookup. My concern was only to avoid calling a function
unnecessarily on !sama5d2 platforms.
>
> > reg = <0x00400000 0x100000>;
> > interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>;
> > clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
> >
>
> Bye,
> --
> Nicolas Ferre
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web