Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node
Date	2016-06-08 12:40 +0200
Message-ID	<rHJ3X-7pn-3@gated-at.bofh.it> (permalink)
References	<rHDhT-3FX-3@gated-at.bofh.it> <rHDhY-3FX-5@gated-at.bofh.it> <rHIAV-7fu-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/06/2016 at 12:06:11 +0200, Nicolas Ferre wrote :
> Le 08/06/2016 06:15, Wenyou Yang a écrit :
> > Use compatible "atmel,sama5d2-ohci" to be capable of suspending
> > ports while sleep to save the power consumption.
> > 
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> > 
> > Changes in v3: None
> > Changes in v2:
> >  - Use the new compatible for ohci-node.
> > 
> >  arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> > index 78996bd..03d6724 100644
> > --- a/arch/arm/boot/dts/sama5d2.dtsi
> > +++ b/arch/arm/boot/dts/sama5d2.dtsi
> > @@ -232,7 +232,7 @@
> >  		};
> >  
> >  		usb1: ohci@00400000 {
> > -			compatible = "atmel,at91rm9200-ohci", "usb-ohci";
> > +			compatible = "atmel,sama5d2-ohci", "usb-ohci";
> 
> We must change this to:
> +			compatible = "atmel,sama5d2-ohci", "atmel,at91rm9200-ohci", "usb-ohci";
> 
> To make it independent from the one that may reach Mainline through the USB git tree.
> 

Well, like discussed, I'd say that a new compatible is not needed as we
already know on which chip we are running depending on the SFR that we
can lookup. My concern was only to avoid calling a function
unnecessarily on !sama5d2 platforms.
> 
> >  			reg = <0x00400000 0x100000>;
> >  			interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>;
> >  			clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
> > 
> 
> Bye,
> -- 
> Nicolas Ferre

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/2] ARM: ohci-at91: Add support to forcibly suspend ports while sleep Wenyou Yang <wenyou.yang@atmel.com> - 2016-06-08 06:30 +0200
  [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node Wenyou Yang <wenyou.yang@atmel.com> - 2016-06-08 06:30 +0200
    Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci  node Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-08 12:10 +0200
      Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for  ohci node Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-08 12:40 +0200

csiph-web