Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1413863 > unrolled thread

Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC

Started byPavel Machek <pavel@ucw.cz>
First post2016-06-04 23:00 +0200
Last post2016-06-06 04:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as  binding to *any* UDC Pavel Machek <pavel@ucw.cz> - 2016-06-04 23:00 +0200
    RE: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as  binding to *any* UDC "Du, Changbin" <changbin.du@intel.com> - 2016-06-06 04:30 +0200

#1413863 — Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC

FromPavel Machek <pavel@ucw.cz>
Date2016-06-04 23:00 +0200
SubjectRe: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC
Message-ID<rGqPM-5Oy-9@gated-at.bofh.it>
On Tue 2016-05-03 11:04:24, changbin.du@intel.com wrote:
> From: "Du, Changbin" <changbin.du@gmail.com>
> 
> On most platforms, there is only one device controller available.
> In this case, we desn't care the UDC's name. So let's ignore the
> name by setting 'UDC' to 'any'. And also we can change UDC name
> at any time if it is not binded (no need set to "" first).

making "any" special does not look like a good idea. What if it really
is "any"?

Return nothing instead, not even \n?

> Signed-off-by: Du, Changbin <changbin.du@gmail.com>
> Signed-off-by: Du, Changbin <changbin.du@intel.com>

I don't think this is how you should sign it off.

Best regards,

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [next] | [standalone]


#1414564

From"Du, Changbin" <changbin.du@intel.com>
Date2016-06-06 04:30 +0200
Message-ID<rGSsF-6CW-7@gated-at.bofh.it>
In reply to#1413863
Thanks, Machek, This patch has already been dropped.

> On Tue 2016-05-03 11:04:24, changbin.du@intel.com wrote:
> > From: "Du, Changbin" <changbin.du@gmail.com>
> >
> > On most platforms, there is only one device controller available.
> > In this case, we desn't care the UDC's name. So let's ignore the
> > name by setting 'UDC' to 'any'. And also we can change UDC name
> > at any time if it is not binded (no need set to "" first).
> 
> making "any" special does not look like a good idea. What if it really
> is "any"?
> 
> Return nothing instead, not even \n?
> 
> > Signed-off-by: Du, Changbin <changbin.du@gmail.com>
> > Signed-off-by: Du, Changbin <changbin.du@intel.com>
> 
> I don't think this is how you should sign it off.
> 
> Best regards,
> 
> 									Pavel
> 
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures)
> http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web