RE: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to any UDC

From	"Du, Changbin" <changbin.du@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to any UDC
Date	2016-06-06 04:30 +0200
Message-ID	<rGSsF-6CW-7@gated-at.bofh.it> (permalink)
References	<ruz2p-4U-3@gated-at.bofh.it> <ruz2p-4U-1@gated-at.bofh.it> <rGqPM-5Oy-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thanks, Machek, This patch has already been dropped.

> On Tue 2016-05-03 11:04:24, changbin.du@intel.com wrote:
> > From: "Du, Changbin" <changbin.du@gmail.com>
> >
> > On most platforms, there is only one device controller available.
> > In this case, we desn't care the UDC's name. So let's ignore the
> > name by setting 'UDC' to 'any'. And also we can change UDC name
> > at any time if it is not binded (no need set to "" first).
> 
> making "any" special does not look like a good idea. What if it really
> is "any"?
> 
> Return nothing instead, not even \n?
> 
> > Signed-off-by: Du, Changbin <changbin.du@gmail.com>
> > Signed-off-by: Du, Changbin <changbin.du@intel.com>
> 
> I don't think this is how you should sign it off.
> 
> Best regards,
> 
> 									Pavel
> 
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures)
> http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as  binding to *any* UDC Pavel Machek <pavel@ucw.cz> - 2016-06-04 23:00 +0200
  RE: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as  binding to *any* UDC "Du, Changbin" <changbin.du@intel.com> - 2016-06-06 04:30 +0200

csiph-web