Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1411867 > unrolled thread
| Started by | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| First post | 2016-06-02 08:20 +0200 |
| Last post | 2016-06-02 12:20 +0200 |
| Articles | 7 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 1/4] mm/init-mm: remove unused header cpumask.h Geliang Tang <geliangtang@gmail.com> - 2016-06-02 08:20 +0200
[PATCH 3/4] mm/vmstat: remove unused header cpumask.h Geliang Tang <geliangtang@gmail.com> - 2016-06-02 08:20 +0200
Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h Michal Hocko <mhocko@kernel.org> - 2016-06-02 08:50 +0200
Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h Christoph Lameter <cl@linux.com> - 2016-06-02 15:50 +0200
[PATCH 2/4] mm: kmemleak: remove unused header cpumask.h Geliang Tang <geliangtang@gmail.com> - 2016-06-02 08:20 +0200
Re: [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h Catalin Marinas <catalin.marinas@arm.com> - 2016-06-02 11:40 +0200
Re: [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h Geliang Tang <geliangtang@gmail.com> - 2016-06-02 12:20 +0200
| From | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| Date | 2016-06-02 08:20 +0200 |
| Subject | [PATCH 1/4] mm/init-mm: remove unused header cpumask.h |
| Message-ID | <rFu93-2i2-5@gated-at.bofh.it> |
Remove unused header cpumask.h from mm/init-mm.c. Signed-off-by: Geliang Tang <geliangtang@gmail.com> --- mm/init-mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/init-mm.c b/mm/init-mm.c index a56a851..2acae89 100644 --- a/mm/init-mm.c +++ b/mm/init-mm.c @@ -3,7 +3,6 @@ #include <linux/rwsem.h> #include <linux/spinlock.h> #include <linux/list.h> -#include <linux/cpumask.h> #include <linux/atomic.h> #include <asm/pgtable.h> -- 1.9.1
[toc] | [next] | [standalone]
| From | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| Date | 2016-06-02 08:20 +0200 |
| Subject | [PATCH 3/4] mm/vmstat: remove unused header cpumask.h |
| Message-ID | <rFu94-2i2-25@gated-at.bofh.it> |
| In reply to | #1411867 |
Remove unused header cpumask.h from mm/vmstat.c. Signed-off-by: Geliang Tang <geliangtang@gmail.com> --- mm/vmstat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 1b585f8..3653449 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -15,7 +15,6 @@ #include <linux/module.h> #include <linux/slab.h> #include <linux/cpu.h> -#include <linux/cpumask.h> #include <linux/vmstat.h> #include <linux/proc_fs.h> #include <linux/seq_file.h> -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Date | 2016-06-02 08:50 +0200 |
| Subject | Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h |
| Message-ID | <rFuC5-2sz-7@gated-at.bofh.it> |
| In reply to | #1411873 |
On Thu 02-06-16 14:15:35, Geliang Tang wrote: > Remove unused header cpumask.h from mm/vmstat.c. what about for_each_online_cpu? Maybe it will get included transitively from other header but I guess it is better to have a direct include because transitive includes lead to unexpected compilation issues. > Signed-off-by: Geliang Tang <geliangtang@gmail.com> > --- > mm/vmstat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 1b585f8..3653449 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -15,7 +15,6 @@ > #include <linux/module.h> > #include <linux/slab.h> > #include <linux/cpu.h> > -#include <linux/cpumask.h> > #include <linux/vmstat.h> > #include <linux/proc_fs.h> > #include <linux/seq_file.h> > -- > 1.9.1 > -- Michal Hocko SUSE Labs
[toc] | [prev] | [next] | [standalone]
| From | Christoph Lameter <cl@linux.com> |
|---|---|
| Date | 2016-06-02 15:50 +0200 |
| Subject | Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h |
| Message-ID | <rFBax-6xM-11@gated-at.bofh.it> |
| In reply to | #1411873 |
On Thu, 2 Jun 2016, Geliang Tang wrote: > Remove unused header cpumask.h from mm/vmstat.c. cpu.h by necessity already includes cpumask.h. So I guess its ok. Acked-by: Christoph Lameter <cl@linux.com>
[toc] | [prev] | [next] | [standalone]
| From | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| Date | 2016-06-02 08:20 +0200 |
| Subject | [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h |
| Message-ID | <rFu94-2i2-33@gated-at.bofh.it> |
| In reply to | #1411867 |
Remove unused header cpumask.h from mm/kmemleak.c. Signed-off-by: Geliang Tang <geliangtang@gmail.com> --- mm/kmemleak.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index e642992..2617309 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -82,7 +82,6 @@ #include <linux/fs.h> #include <linux/debugfs.h> #include <linux/seq_file.h> -#include <linux/cpumask.h> #include <linux/spinlock.h> #include <linux/mutex.h> #include <linux/rcupdate.h> -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Catalin Marinas <catalin.marinas@arm.com> |
|---|---|
| Date | 2016-06-02 11:40 +0200 |
| Subject | Re: [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h |
| Message-ID | <rFxgC-4bE-13@gated-at.bofh.it> |
| In reply to | #1411875 |
On Thu, Jun 02, 2016 at 02:15:34PM +0800, Geliang Tang wrote: > Remove unused header cpumask.h from mm/kmemleak.c. > > Signed-off-by: Geliang Tang <geliangtang@gmail.com> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
[toc] | [prev] | [next] | [standalone]
| From | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| Date | 2016-06-02 12:20 +0200 |
| Subject | Re: [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h |
| Message-ID | <rFxTj-4Ge-9@gated-at.bofh.it> |
| In reply to | #1412053 |
On Thu, Jun 02, 2016 at 10:32:41AM +0100, Catalin Marinas wrote: > On Thu, Jun 02, 2016 at 02:15:34PM +0800, Geliang Tang wrote: > > Remove unused header cpumask.h from mm/kmemleak.c. > > > > Signed-off-by: Geliang Tang <geliangtang@gmail.com> > > Acked-by: Catalin Marinas <catalin.marinas@arm.com> This patch is incorrect because for_each_possible_cpu() is defined in cpumask.h. Sorry about that. -Geliang
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web