Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411905

Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h

Show all headers | View raw

On Thu 02-06-16 14:15:35, Geliang Tang wrote:
> Remove unused header cpumask.h from mm/vmstat.c.

what about for_each_online_cpu? Maybe it will get included transitively
from other header but I guess it is better to have a direct include
because transitive includes lead to unexpected compilation issues.

> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
>  mm/vmstat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 1b585f8..3653449 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -15,7 +15,6 @@
>  #include <linux/module.h>
>  #include <linux/slab.h>
>  #include <linux/cpu.h>
> -#include <linux/cpumask.h>
>  #include <linux/vmstat.h>
>  #include <linux/proc_fs.h>
>  #include <linux/seq_file.h>
> -- 
> 1.9.1
> 

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] mm/init-mm: remove unused header cpumask.h Geliang Tang <geliangtang@gmail.com> - 2016-06-02 08:20 +0200
  [PATCH 3/4] mm/vmstat: remove unused header cpumask.h Geliang Tang <geliangtang@gmail.com> - 2016-06-02 08:20 +0200
    Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h Michal Hocko <mhocko@kernel.org> - 2016-06-02 08:50 +0200
    Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h Christoph Lameter <cl@linux.com> - 2016-06-02 15:50 +0200
  [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h Geliang Tang <geliangtang@gmail.com> - 2016-06-02 08:20 +0200
    Re: [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h Catalin Marinas <catalin.marinas@arm.com> - 2016-06-02 11:40 +0200
      Re: [PATCH 2/4] mm: kmemleak: remove unused header cpumask.h Geliang Tang <geliangtang@gmail.com> - 2016-06-02 12:20 +0200

csiph-web