Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411514 > unrolled thread

Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Kevin Hilman <khilman@kernel.org> - 2016-06-01 22:00 +0200
    Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-06-01 22:10 +0200
      Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-01 23:00 +0200
        Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-01 23:00 +0200
          Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-06-02 06:20 +0200

#1411514 — Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410

Hi Krzysztof,

On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Just like other Exynos5 family SoCs, this one has four UARTs. Configure
> clocks for UART3 and enable it.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

This patch landed in linux-next[1] and kernelci.org found a boot
regression on the exynos5410-odroidxu[2], where it looks like it's
faulting in clk_prepare().  Bisecting pointed to this patch.  I added
"status = disabled" back into the DTS on top of next-20160601[3] and
verified my odroid-XU to be booting fine again.

Kevin

[1] 594127ada6df ARM: dts: exynos: Enable UART3 on Exynos5410
[2] https://kernelci.org/boot/exynos5410-odroidxu/job/next/kernel/next-20160601/defconfig/multi_v7_defconfig/lab/lab-baylibre-seattle/?_id=574e97c759b5140f4141c8ef
[3] diff --git a/arch/arm/boot/dts/exynos5410.dtsi
b/arch/arm/boot/dts/exynos5410.dtsi
index a937d9bdad90..f4baf1d1e864 100644
--- a/arch/arm/boot/dts/exynos5410.dtsi
+++ b/arch/arm/boot/dts/exynos5410.dtsi
@@ -238,6 +238,7 @@
 };

 &serial_3 {
+       status = "disabled";
        clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>;
        clock-names = "uart", "clk_uart_baud0";
 };

[toc] | [next] | [standalone]

#1411519

On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman <khilman@kernel.org> wrote:
> Hi Krzysztof,
>
> On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> Just like other Exynos5 family SoCs, this one has four UARTs. Configure
>> clocks for UART3 and enable it.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> This patch landed in linux-next[1] and kernelci.org found a boot
> regression on the exynos5410-odroidxu[2], where it looks like it's
> faulting in clk_prepare().  Bisecting pointed to this patch.  I added
> "status = disabled" back into the DTS on top of next-20160601[3] and
> verified my odroid-XU to be booting fine again.

Hi,

Thanks for report. Indeed the patch brings up to the light an issue in
serial driver. Fixed here:
https://lkml.org/lkml/2016/5/31/570

I left the commit in my tree as it is correct (strictly speaking).
Sorry for any trouble it makes.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1411536

Hello Krzysztof,

On 06/01/2016 04:06 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman <khilman@kernel.org> wrote:
>> Hi Krzysztof,
>>
>> On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> Just like other Exynos5 family SoCs, this one has four UARTs. Configure
>>> clocks for UART3 and enable it.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> This patch landed in linux-next[1] and kernelci.org found a boot
>> regression on the exynos5410-odroidxu[2], where it looks like it's
>> faulting in clk_prepare().  Bisecting pointed to this patch.  I added
>> "status = disabled" back into the DTS on top of next-20160601[3] and
>> verified my odroid-XU to be booting fine again.
> 
> Hi,
> 
> Thanks for report. Indeed the patch brings up to the light an issue in
> serial driver. Fixed here:
> https://lkml.org/lkml/2016/5/31/570
> 
> I left the commit in my tree as it is correct (strictly speaking).
> Sorry for any trouble it makes.
>

Kevin pointed me to this issue over IRC and I was able to reproduce it in
my Peach Pi by removing the UART3 clocks from the Exynos5420 clock driver.

Your patch indeed fixes the issue, I'll add a Reviewed-by on that thread.
 
> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1411538

On 06/01/2016 04:52 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,

[snip]

>>
>> I left the commit in my tree as it is correct (strictly speaking).
>> Sorry for any trouble it makes.
>>
> 
> Kevin pointed me to this issue over IRC and I was able to reproduce it in
> my Peach Pi by removing the UART3 clocks from the Exynos5420 clock driver.
> 
> Your patch indeed fixes the issue, I'll add a Reviewed-by on that thread.
> 

err, I meant a Tested-by tag... but yes I've also reviewed the patch :)

Best regards, 
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1411804

On 06/01/2016 10:54 PM, Javier Martinez Canillas wrote:
> On 06/01/2016 04:52 PM, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
> 
> [snip]
> 
>>>
>>> I left the commit in my tree as it is correct (strictly speaking).
>>> Sorry for any trouble it makes.
>>>
>>
>> Kevin pointed me to this issue over IRC and I was able to reproduce it in
>> my Peach Pi by removing the UART3 clocks from the Exynos5420 clock driver.
>>
>> Your patch indeed fixes the issue, I'll add a Reviewed-by on that thread.
>>
> 
> err, I meant a Tested-by tag... but yes I've also reviewed the patch :)

Sure, thanks!

Best regards,
Krzysztof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web