Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410
Date	2016-06-01 23:00 +0200
Message-ID	<rFlp7-51f-1@gated-at.bofh.it> (permalink)
References	<rDJcd-7iX-3@gated-at.bofh.it> <rDJci-7iX-13@gated-at.bofh.it> <rFkt4-4lQ-23@gated-at.bofh.it> <rFkCK-4FN-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Krzysztof,

On 06/01/2016 04:06 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman <khilman@kernel.org> wrote:
>> Hi Krzysztof,
>>
>> On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> Just like other Exynos5 family SoCs, this one has four UARTs. Configure
>>> clocks for UART3 and enable it.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> This patch landed in linux-next[1] and kernelci.org found a boot
>> regression on the exynos5410-odroidxu[2], where it looks like it's
>> faulting in clk_prepare().  Bisecting pointed to this patch.  I added
>> "status = disabled" back into the DTS on top of next-20160601[3] and
>> verified my odroid-XU to be booting fine again.
> 
> Hi,
> 
> Thanks for report. Indeed the patch brings up to the light an issue in
> serial driver. Fixed here:
> https://lkml.org/lkml/2016/5/31/570
> 
> I left the commit in my tree as it is correct (strictly speaking).
> Sorry for any trouble it makes.
>

Kevin pointed me to this issue over IRC and I was able to reproduce it in
my Peach Pi by removing the UART3 clocks from the Exynos5420 clock driver.

Your patch indeed fixes the issue, I'll add a Reviewed-by on that thread.
 
> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Thread

Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Kevin Hilman <khilman@kernel.org> - 2016-06-01 22:00 +0200
  Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-06-01 22:10 +0200
    Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-01 23:00 +0200
      Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-01 23:00 +0200
        Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Krzysztof Kozlowski <krzk@kernel.org> - 2016-06-02 06:20 +0200

csiph-web