Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411185 > unrolled thread

Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM?

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM? Simon Marchi <simon.marchi@ericsson.com> - 2016-06-01 15:00 +0200
    Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM? Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-02 15:20 +0200
      Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM? Simon Marchi <simon.marchi@ericsson.com> - 2016-06-02 15:20 +0200

#1411185 — Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM?

On 16-05-30 05:35 PM, Russell King - ARM Linux wrote:
> So, the gdb verisons I have here seem to be particularly poor - but with
> some modifications, I can test out on iMX6 by forcing gdb to do the right
> thing - by inserting a couple of "mov r0, r0" instructions after the
> "break_here" label.

I see that problem too with older versions, bisecting shows it has been fixed
in commit

  6e22494e5076 Do not skip prologue for asm (.S) files

in gdb, which is included in gdb 7.10 and up.

> With that, on a single CPU, it seems to work correctly every time, but
> if I bring up a secondary CPU I start seeing the same problems you've
> reported - which seems to need the following patch to solve.  Please can
> you check whether this resolves your problem?

Yes that fixes the problem, the test case succeeds every time.  I have stared
at those lines in ptrace.c for some time, but couldn't find the problem.  Thanks
for looking into it!

[toc] | [next] | [standalone]

#1412219

On Wed, Jun 01, 2016 at 08:54:05AM -0400, Simon Marchi wrote:
> On 16-05-30 05:35 PM, Russell King - ARM Linux wrote:
> > So, the gdb verisons I have here seem to be particularly poor - but with
> > some modifications, I can test out on iMX6 by forcing gdb to do the right
> > thing - by inserting a couple of "mov r0, r0" instructions after the
> > "break_here" label.
> 
> I see that problem too with older versions, bisecting shows it has been fixed
> in commit
> 
>   6e22494e5076 Do not skip prologue for asm (.S) files
> 
> in gdb, which is included in gdb 7.10 and up.
> 
> > With that, on a single CPU, it seems to work correctly every time, but
> > if I bring up a secondary CPU I start seeing the same problems you've
> > reported - which seems to need the following patch to solve.  Please can
> > you check whether this resolves your problem?
> 
> Yes that fixes the problem, the test case succeeds every time.  I have stared
> at those lines in ptrace.c for some time, but couldn't find the problem.  Thanks
> for looking into it!

Hi, can I add a:

Tested-by: Simon Marchi <simon.marchi@ericsson.com>

tag to the commit please?

Many thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[toc] | [prev] | [next] | [standalone]

#1412225

On 16-06-02 09:15 AM, Russell King - ARM Linux wrote:
> Hi, can I add a:
> 
> Tested-by: Simon Marchi <simon.marchi@ericsson.com>
> 
> tag to the commit please?

Yes, of course.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web