Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM?

From	Simon Marchi <simon.marchi@ericsson.com>
Newsgroups	linux.kernel
Subject	Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM?
Date	2016-06-01 15:00 +0200
Message-ID	<rFdUD-8wg-29@gated-at.bofh.it> (permalink)
References	<rEzNv-7IN-9@gated-at.bofh.it> <rED4K-1qz-41@gated-at.bofh.it>
Organization	Ericsson AB

Show all headers | View raw

On 16-05-30 05:35 PM, Russell King - ARM Linux wrote:
> So, the gdb verisons I have here seem to be particularly poor - but with
> some modifications, I can test out on iMX6 by forcing gdb to do the right
> thing - by inserting a couple of "mov r0, r0" instructions after the
> "break_here" label.

I see that problem too with older versions, bisecting shows it has been fixed
in commit

  6e22494e5076 Do not skip prologue for asm (.S) files

in gdb, which is included in gdb 7.10 and up.

> With that, on a single CPU, it seems to work correctly every time, but
> if I bring up a secondary CPU I start seeing the same problems you've
> reported - which seems to need the following patch to solve.  Please can
> you check whether this resolves your problem?

Yes that fixes the problem, the test case succeeds every time.  I have stared
at those lines in ptrace.c for some time, but couldn't find the problem.  Thanks
for looking into it!

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM? Simon Marchi <simon.marchi@ericsson.com> - 2016-06-01 15:00 +0200
  Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM? Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-02 15:20 +0200
    Re: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM? Simon Marchi <simon.marchi@ericsson.com> - 2016-06-02 15:20 +0200

csiph-web