Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1412218 > unrolled thread
| Started by | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| First post | 2016-06-02 15:20 +0200 |
| Last post | 2016-06-04 01:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2016-06-02 15:20 +0200
Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2016-06-02 15:40 +0200
Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency Grygorii Strashko <grygorii.strashko@ti.com> - 2016-06-03 18:50 +0200
Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency David Miller <davem@davemloft.net> - 2016-06-04 01:40 +0200
| From | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| Date | 2016-06-02 15:20 +0200 |
| Subject | [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency |
| Message-ID | <rFAHv-6o5-3@gated-at.bofh.it> |
The rx-usecs shouldn't be changed while interface down/up.
Currently, for instance, if it's set to 100us, after interface
down/up it's 500us. It's a hidden bug that can lead to lavish
interrupt pacing time increasing while "down/up" up to max value.
Steps to reproduce:
- set rx-usecs to be 100us
- down/up interface
- read new unexpected rx-usecs
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on ti-linux-4.4.y
drivers/net/ethernet/ti/cpsw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 7b44587..9919cb3 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1352,7 +1352,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
if (priv->coal_intvl != 0) {
struct ethtool_coalesce coal;
- coal.rx_coalesce_usecs = (priv->coal_intvl << 4);
+ coal.rx_coalesce_usecs = priv->coal_intvl;
cpsw_set_coalesce(ndev, &coal);
}
--
1.9.1
[toc] | [next] | [standalone]
| From | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| Date | 2016-06-02 15:40 +0200 |
| Subject | Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency |
| Message-ID | <rFB0R-6uu-7@gated-at.bofh.it> |
| In reply to | #1412218 |
On 02.06.16 16:14, Ivan Khoronzhuk wrote:
> The rx-usecs shouldn't be changed while interface down/up.
> Currently, for instance, if it's set to 100us, after interface
> down/up it's 500us. It's a hidden bug that can lead to lavish
> interrupt pacing time increasing while "down/up" up to max value.
>
> Steps to reproduce:
> - set rx-usecs to be 100us
> - down/up interface
> - read new unexpected rx-usecs
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>
> Based on ti-linux-4.4.y
Please ignore this line, it's added by mistake.
The patch is based on master.
>
> drivers/net/ethernet/ti/cpsw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 7b44587..9919cb3 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1352,7 +1352,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
> if (priv->coal_intvl != 0) {
> struct ethtool_coalesce coal;
>
> - coal.rx_coalesce_usecs = (priv->coal_intvl << 4);
> + coal.rx_coalesce_usecs = priv->coal_intvl;
> cpsw_set_coalesce(ndev, &coal);
> }
>
>
--
Regards,
Ivan Khoronzhuk
[toc] | [prev] | [next] | [standalone]
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2016-06-03 18:50 +0200 |
| Subject | Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency |
| Message-ID | <rG0sh-5FK-1@gated-at.bofh.it> |
| In reply to | #1412234 |
On 06/02/2016 04:30 PM, Ivan Khoronzhuk wrote:
> On 02.06.16 16:14, Ivan Khoronzhuk wrote:
>> The rx-usecs shouldn't be changed while interface down/up.
>> Currently, for instance, if it's set to 100us, after interface
>> down/up it's 500us. It's a hidden bug that can lead to lavish
>> interrupt pacing time increasing while "down/up" up to max value.
>>
>> Steps to reproduce:
>> - set rx-usecs to be 100us
>> - down/up interface
>> - read new unexpected rx-usecs
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>> ---
>>
>> Based on ti-linux-4.4.y
> Please ignore this line, it's added by mistake.
> The patch is based on master.
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
>>
>> drivers/net/ethernet/ti/cpsw.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/ti/cpsw.c
>> b/drivers/net/ethernet/ti/cpsw.c
>> index 7b44587..9919cb3 100644
>> --- a/drivers/net/ethernet/ti/cpsw.c
>> +++ b/drivers/net/ethernet/ti/cpsw.c
>> @@ -1352,7 +1352,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
>> if (priv->coal_intvl != 0) {
>> struct ethtool_coalesce coal;
>>
>> - coal.rx_coalesce_usecs = (priv->coal_intvl << 4);
>> + coal.rx_coalesce_usecs = priv->coal_intvl;
>> cpsw_set_coalesce(ndev, &coal);
>> }
>>
>>
>
--
regards,
-grygorii
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-04 01:40 +0200 |
| Subject | Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency |
| Message-ID | <rG6R4-1cd-21@gated-at.bofh.it> |
| In reply to | #1412218 |
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> Date: Thu, 2 Jun 2016 16:14:52 +0300 > The rx-usecs shouldn't be changed while interface down/up. > Currently, for instance, if it's set to 100us, after interface > down/up it's 500us. It's a hidden bug that can lead to lavish > interrupt pacing time increasing while "down/up" up to max value. > > Steps to reproduce: > - set rx-usecs to be 100us > - down/up interface > - read new unexpected rx-usecs > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web