Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1413354

Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency

Show all headers | View raw

On 06/02/2016 04:30 PM, Ivan Khoronzhuk wrote:
> On 02.06.16 16:14, Ivan Khoronzhuk wrote:
>> The rx-usecs shouldn't be changed while interface down/up.
>> Currently, for instance, if it's set to 100us, after interface
>> down/up it's 500us. It's a hidden bug that can lead to lavish
>> interrupt pacing time increasing while "down/up" up to max value.
>>
>> Steps to reproduce:
>> - set rx-usecs to be 100us
>> - down/up interface
>> - read new unexpected rx-usecs
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>> ---
>>
>> Based on ti-linux-4.4.y
> Please ignore this line, it's added by mistake.
> The patch is based on master.
>

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

>
>>
>>   drivers/net/ethernet/ti/cpsw.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/ti/cpsw.c
>> b/drivers/net/ethernet/ti/cpsw.c
>> index 7b44587..9919cb3 100644
>> --- a/drivers/net/ethernet/ti/cpsw.c
>> +++ b/drivers/net/ethernet/ti/cpsw.c
>> @@ -1352,7 +1352,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
>>       if (priv->coal_intvl != 0) {
>>           struct ethtool_coalesce coal;
>>
>> -        coal.rx_coalesce_usecs = (priv->coal_intvl << 4);
>> +        coal.rx_coalesce_usecs = priv->coal_intvl;
>>           cpsw_set_coalesce(ndev, &coal);
>>       }
>>
>>
>


-- 
regards,
-grygorii

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2016-06-02 15:20 +0200
  Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing  consistency Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2016-06-02 15:40 +0200
    Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing  consistency Grygorii Strashko <grygorii.strashko@ti.com> - 2016-06-03 18:50 +0200
  Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing  consistency David Miller <davem@davemloft.net> - 2016-06-04 01:40 +0200

csiph-web