Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410639 > unrolled thread

Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper Oleg Nesterov <oleg@redhat.com> - 2016-05-31 23:30 +0200

#1410639 — Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper

On 05/31, Michal Hocko wrote:
>
> @@ -636,10 +634,7 @@ void try_oom_reaper(struct task_struct *tsk)
>  			 * If the task is exiting make sure the whole thread group
>  			 * is exiting and cannot acces mm anymore.
>  			 */
> -			spin_lock_irq(&p->sighand->siglock);
> -			exiting = signal_group_exit(p->signal);
> -			spin_unlock_irq(&p->sighand->siglock);
> -			if (exiting)
> +			if (signal_group_exit(p->signal))
>  				continue;

Yes, thanks Michal. signal_group_exit() is not really right too (coredump)
but this is not that important and you are going to rework this code anyway.

Oleg.

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web