Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper
Date	2016-05-31 23:30 +0200
Message-ID	<rEZoC-7SC-31@gated-at.bofh.it> (permalink)
References	<rEMhI-7Yx-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/31, Michal Hocko wrote:
>
> @@ -636,10 +634,7 @@ void try_oom_reaper(struct task_struct *tsk)
>  			 * If the task is exiting make sure the whole thread group
>  			 * is exiting and cannot acces mm anymore.
>  			 */
> -			spin_lock_irq(&p->sighand->siglock);
> -			exiting = signal_group_exit(p->signal);
> -			spin_unlock_irq(&p->sighand->siglock);
> -			if (exiting)
> +			if (signal_group_exit(p->signal))
>  				continue;

Yes, thanks Michal. signal_group_exit() is not really right too (coredump)
but this is not that important and you are going to rework this code anyway.

Oleg.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper Oleg Nesterov <oleg@redhat.com> - 2016-05-31 23:30 +0200

csiph-web