Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1408836 > unrolled thread

[PATCH] mmc: host: use pr_err for sdhci_dumpregs

Started by"Baranowska, BeataX" <beatax.baranowska@intel.com>
First post2016-05-30 10:00 +0200
Last post2016-06-01 07:20 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] mmc: host: use pr_err for sdhci_dumpregs "Baranowska, BeataX" <beatax.baranowska@intel.com> - 2016-05-30 10:00 +0200
    Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-05-31 17:50 +0200
      RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs "Baranowska, BeataX" <beatax.baranowska@intel.com> - 2016-06-01 07:20 +0200

#1408836 — [PATCH] mmc: host: use pr_err for sdhci_dumpregs

From"Baranowska, BeataX" <beatax.baranowska@intel.com>
Date2016-05-30 10:00 +0200
Subject[PATCH] mmc: host: use pr_err for sdhci_dumpregs
Message-ID<rEqhb-1fU-7@gated-at.bofh.it>
From: Chuanxiao Dong <chuanxiao.dong@intel.com>

sdhci_dumpregs is used to dump registers when error happens. Thus it should
use pr_err instead of pr_debug to show more information about the hardware.

Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
---
drivers/mmc/host/sdhci.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index e010ea4eb6f5..99441742d86e 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -52,58 +52,58 @@ static int sdhci_get_cd(struct mmc_host *mmc);

 static void sdhci_dumpregs(struct sdhci_host *host)
 {
-       pr_debug(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
+       pr_err(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
                mmc_hostname(host->mmc));

-       pr_debug(DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
+       pr_err(DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
                sdhci_readl(host, SDHCI_DMA_ADDRESS),
                sdhci_readw(host, SDHCI_HOST_VERSION));
-       pr_debug(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt:  0x%08x\n",
+       pr_err(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt:  0x%08x\n",
                sdhci_readw(host, SDHCI_BLOCK_SIZE),
                sdhci_readw(host, SDHCI_BLOCK_COUNT));
-       pr_debug(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n",
                sdhci_readl(host, SDHCI_ARGUMENT),
                sdhci_readw(host, SDHCI_TRANSFER_MODE));
-       pr_debug(DRIVER_NAME ": Present:  0x%08x | Host ctl: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Present:  0x%08x | Host ctl: 0x%08x\n",
                sdhci_readl(host, SDHCI_PRESENT_STATE),
                sdhci_readb(host, SDHCI_HOST_CONTROL));
-       pr_debug(DRIVER_NAME ": Power:    0x%08x | Blk gap:  0x%08x\n",
+       pr_err(DRIVER_NAME ": Power:    0x%08x | Blk gap:  0x%08x\n",
                sdhci_readb(host, SDHCI_POWER_CONTROL),
                sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL));
-       pr_debug(DRIVER_NAME ": Wake-up:  0x%08x | Clock:    0x%08x\n",
+       pr_err(DRIVER_NAME ": Wake-up:  0x%08x | Clock:    0x%08x\n",
                sdhci_readb(host, SDHCI_WAKE_UP_CONTROL),
                sdhci_readw(host, SDHCI_CLOCK_CONTROL));
-       pr_debug(DRIVER_NAME ": Timeout:  0x%08x | Int stat: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Timeout:  0x%08x | Int stat: 0x%08x\n",
                sdhci_readb(host, SDHCI_TIMEOUT_CONTROL),
                sdhci_readl(host, SDHCI_INT_STATUS));
-       pr_debug(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n",
                sdhci_readl(host, SDHCI_INT_ENABLE),
                sdhci_readl(host, SDHCI_SIGNAL_ENABLE));
-       pr_debug(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n",
+       pr_err(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n",
                sdhci_readw(host, SDHCI_ACMD12_ERR),
                sdhci_readw(host, SDHCI_SLOT_INT_STATUS));
-       pr_debug(DRIVER_NAME ": Caps:     0x%08x | Caps_1:   0x%08x\n",
+       pr_err(DRIVER_NAME ": Caps:     0x%08x | Caps_1:   0x%08x\n",
                sdhci_readl(host, SDHCI_CAPABILITIES),
                sdhci_readl(host, SDHCI_CAPABILITIES_1));
-       pr_debug(DRIVER_NAME ": Cmd:      0x%08x | Max curr: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Cmd:      0x%08x | Max curr: 0x%08x\n",
                sdhci_readw(host, SDHCI_COMMAND),
                sdhci_readl(host, SDHCI_MAX_CURRENT));
-       pr_debug(DRIVER_NAME ": Host ctl2: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Host ctl2: 0x%08x\n",
                sdhci_readw(host, SDHCI_HOST_CONTROL2));

        if (host->flags & SDHCI_USE_ADMA) {
                if (host->flags & SDHCI_USE_64_BIT_DMA)
-                       pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n",
+                       pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n",
                                 readl(host->ioaddr + SDHCI_ADMA_ERROR),
                                 readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI),
                                 readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
                else
-                       pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n",
+                       pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n",
                                 readl(host->ioaddr + SDHCI_ADMA_ERROR),
                                 readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
        }

-       pr_debug(DRIVER_NAME ": ===========================================\n");
+       pr_err(DRIVER_NAME ": ===========================================\n");
 }

 /*****************************************************************************\
--


Regards,
Beata Baranowska

Intel Technology Poland sp. z o.o.
ul. Słowackiego 173 | 80-298 Gdańsk 
Sąd Rejonowy Gdańsk Północ 
VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 
NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN

[toc] | [next] | [standalone]

#1410382

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2016-05-31 17:50 +0200
Message-ID<rEU5z-4yc-3@gated-at.bofh.it>
In reply to#1408836
On Mon, May 30, 2016 at 10:59 AM, Baranowska, BeataX
<beatax.baranowska@intel.com> wrote:
> From: Chuanxiao Dong <chuanxiao.dong@intel.com>
>
> sdhci_dumpregs is used to dump registers when error happens. Thus it should
> use pr_err instead of pr_debug to show more information about the hardware.
>

Wouldn't be too noisy?

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1410822

From"Baranowska, BeataX" <beatax.baranowska@intel.com>
Date2016-06-01 07:20 +0200
Message-ID<rF6Jr-4ev-3@gated-at.bofh.it>
In reply to#1410382
> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Tuesday, May 31, 2016 5:47 PM
> To: Baranowska, BeataX <beatax.baranowska@intel.com>
> Cc: Hunter, Adrian <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org; linux-
> kernel@vger.kernel.org; Dong, Chuanxiao <chuanxiao.dong@intel.com>;
> Jarosz, SebastianX <sebastianx.jarosz@intel.com>
> Subject: Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs
> 
> On Mon, May 30, 2016 at 10:59 AM, Baranowska, BeataX
> <beatax.baranowska@intel.com> wrote:
> > From: Chuanxiao Dong <chuanxiao.dong@intel.com>
> >
> > sdhci_dumpregs is used to dump registers when error happens. Thus it
> > should use pr_err instead of pr_debug to show more information about
> the hardware.
> >
> 
> Wouldn't be too noisy?
> 
> --
> With Best Regards,
> Andy Shevchenko

It is when error happens so IMHO it should be well visible.

Regards,
Beata Baranowska

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web